Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD][MIG][12.0] stock_orderpoint_route #785

Merged
merged 4 commits into from Apr 4, 2022
Merged

[ADD][MIG][12.0] stock_orderpoint_route #785

merged 4 commits into from Apr 4, 2022

Conversation

guewen
Copy link
Member

@guewen guewen commented Dec 5, 2019 •
edited

Port to 12.0 of #537

This module allows to restrict a specific route to be used in the
reordering rules. This route will be used instead of the default determined by
default.

@guewen guewen force-pushed the 12.0-stock_orderpoint_route branch 2 times, most recently from 2cfb0cf to a63a13c Compare December 5, 2019 10:23
@LoisRForgeFlow
Copy link
Contributor

As you propsed in the other PR:

BTW, don't you think the orderpoint_selectable on the routes make sense to have the same mechanism as the others (sale order line selectable, ...)?

I think that's a good idea if you want to include it here.

@guewen guewen force-pushed the 12.0-stock_orderpoint_route branch from a63a13c to ac7f55e Compare December 5, 2019 12:29
@rousseldenis rousseldenis added this to the 12.0 milestone Dec 5, 2019
rousseldenis
rousseldenis approved these changes Dec 5, 2019
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor comment

stock_orderpoint_route/__manifest__.py Outdated
"author": "Eficent, "
"Camptocamp, "
"Odoo Community Association (OCA)",
"category": "Warehouse Management",
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set this to 'Warehouse'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@OCA-git-bot OCA-git-bot mentioned this pull request Dec 5, 2019
Closed
54 tasks
@guewen guewen mentioned this pull request Dec 19, 2019
Merged
@dreispt
Copy link
Sponsor Member

dreispt commented Nov 29, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-785-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 29, 2021
@OCA-git-bot
Merge PR #785 into 12.0
5d891be 
Signed-off-by dreispt
@github-actions
Copy link

github-actions bot commented Apr 3, 2022

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 3, 2022
@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-785-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit aa170ac into OCA:12.0 Apr 4, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 23f0c98. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@JordiBForgeFlow JordiBForgeFlow Awaiting requested review from JordiBForgeFlow

@LoisRForgeFlow LoisRForgeFlow Awaiting requested review from LoisRForgeFlow

Assignees
No one assigned
Labels
merged 🎉 needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@guewen @LoisRForgeFlow @dreispt @OCA-git-bot @rousseldenis @JordiBForgeFlow