-
-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG][13.0] stock_orderpoint_route: Migration to 13.0 #807
Conversation
433f65b
to
ff7df45
Compare
To avoid executing the setup for each test
ff7df45
to
56fb322
Compare
* performance (less queries executed) * disable tracking in tests (faster) * use with_user instead of sudo * the double for loop in _compute_route_ids actually generates one more query as the simple one in this commit (thanks to the cache) * extract a method * the parent locations can be found using 'parent_of' which will use the parent_path under the hood (example: 1/7/8 will return locations 1, 7, 8)
@simahawk rebased, fixed your comments in the last commit |
@JordiBForgeFlow could you pass by for a review? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review is ok on my side
This PR has the |
/ocabot merge |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 0ad9994. Thanks a lot for contributing to OCA. ❤️ |
Port #785, #537