Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][13.0] stock_orderpoint_route: Migration to 13.0 #807

Merged
merged 7 commits into from
Mar 23, 2020

Conversation

guewen
Copy link
Member

@guewen guewen commented Dec 19, 2019

Port #785, #537

@max3903 max3903 added this to the 13.0 milestone Dec 31, 2019
@guewen guewen force-pushed the 13.0-mig-stock_orderpoint_route branch from 433f65b to ff7df45 Compare January 7, 2020 06:28
@guewen guewen force-pushed the 13.0-mig-stock_orderpoint_route branch from ff7df45 to 56fb322 Compare March 17, 2020 10:14
* performance (less queries executed)
* disable tracking in tests (faster)
* use with_user instead of sudo
* the double for loop in _compute_route_ids actually generates one more
  query as the simple one in this commit (thanks to the cache)
* extract a method
* the parent locations can be found using 'parent_of' which will use the
  parent_path under the hood (example: 1/7/8 will return locations 1, 7,
  8)
@guewen
Copy link
Member Author

guewen commented Mar 17, 2020

@simahawk rebased, fixed your comments in the last commit

@simahawk
Copy link
Contributor

@JordiBForgeFlow could you pass by for a review? :)

Copy link
Member

@jgrandguillaume jgrandguillaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review is ok on my side

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@simahawk
Copy link
Contributor

/ocabot merge

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-807-by-simahawk-bump-no, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0ad9994. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 9eeb405 into OCA:13.0 Mar 23, 2020
CarlosRoca13 pushed a commit to Tecnativa/stock-logistics-warehouse that referenced this pull request Aug 16, 2021
Signed-off-by simahawk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants