[13.0][MIG] stock_available_unreserved #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [ADD] new module 'stock_available_unreserved'
_product_available() method is computed only once by location
Read quants without lang into the context to avoid sql join on ir.translations Iter on product with prefetch_fields=False and lang='' to avoid reading useless column ad join on ir.translations
The computation of the unreserved available amount using the StockQuant._get_available_quantity was wrong as soon as more than one quant was found for the same product. It can easily happen when you have sublocations and a quant in each location. The reason is that the algorithm was: 1. searching for all the quants for a given product 2. calling StockQuant._get_available_quantity for each quant 3. _get_available_quantity is an @api.model method, which itself will search for all quants for the product and the given location and children Which means that if you have these locations: Stock Stock > Bin A Stock > Bin B And these quants: 1. Product: Product A Location: Bin A Quantity: 60 Reserved: 0 2. Product: Product A Location: Bin B Quantity: 10 Reserved: 0 Instead of 70, the result was 140. (One loop for each quant, each loop recomputing the total quantity in _get_available_quantity, all summed togethed, for each new quant, an additional sum would be added). Ultimately, the _get_available_quantity method does the sum of (quantity - quantity reserved). This commit uses the same logic than the 10.0 branch, it finds the quants contextually using ProductProduct._get_domain_locations and get the available quantity as the sum of (quantity - quantity reserved). We can't really use StockQuant._get_available_quantity because this one expects a location, while here we don't necessarily know it. I removed _product_available_not_res_hook which seems to have no purpose, it does not receive the result of the computation and its own result is unused.
…not_reserved compute method in order to update the quantity.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_available_unreserved Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_available_unreserved/
Currently translated at 38.5% (5 of 13 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_available_unreserved Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_available_unreserved/zh_CN/
Currently translated at 100.0% (13 of 13 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_available_unreserved Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_available_unreserved/es/
* update author's name after recent rebranding of Eficent to ForgeFlow. * change license to lgpl as agreed by the authors. * update readme to new format.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_available_unreserved Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_available_unreserved/
|
Hey @LoisRForgeFlow, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
This comment has been minimized.
This comment has been minimized.
Standard migration. Also some copyrights are removed because they were added by mistake in the fist place (copy+paste issues ;) )
LoisRForgeFlow
force-pushed
the
13.0-mig-stock_available_unreserved
branch
from
fecc8a0
to
9fecf39
Compare
This comment has been minimized.
This comment has been minimized.
This was referenced Dec 30, 2019
Closed
AaronHForgeFlow
approved these changes
Dec 30, 2019
|
/ocabot merge |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
OCA-git-bot
added a commit
that referenced
this pull request
Dec 30, 2019
|
Congratulations, your PR was merged at 193e0e5. Thanks a lot for contributing to OCA. ❤️ |
|
Hi, @LoisRForgeFlow. |
|
@kos94ok-3D I cannot find it, could you point me the code? |
|
@kos94ok-3D @LoisRForgeFlow |
CarlosRoca13
pushed a commit
to Tecnativa/stock-logistics-warehouse
that referenced
this pull request
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard migration to v13.
@ForgeFlow