-
-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
13.0 mig stock location lockdown #991
13.0 mig stock location lockdown #991
Conversation
@manuelregidor could you recheck pre-commit? |
6da957b
to
4db3238
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This PR has the |
@OCA/logistics-maintainers could this one be merged? |
You're in a hurry ? 7 days old. A baby 😃 |
/ocabot merge patch |
This PR looks fantastic, let's merge it! |
@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-991-by-rousseldenis-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
Lately, I'm always in a hurry. Thanks @rousseldenis 👍 |
@manuelregidor Could you rebase ? |
4db3238
to
0f75b33
Compare
@rousseldenis Rebase done |
@rousseldenis Travis has failed due to an unrelated travis error. Apparently there is something wrong with a test in module 'stock_vertical_lift_storage_type module', which has no relation with the module I have migrated. How should we proceed? Thank you. |
We are suffering the same in #998. Either you fix it and put a new PR or put an issue pinging the authors/maintainers of such module. It will be probably a change upstream that has impacted in the module. |
@pedrobaeza If I have time to test I will objectivate it but I think this is due to odoo/odoo@51b7960 |
Here seems to be the fix for the issue #1000 |
Currently translated at 100.0% (6 of 6 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_location_lockdown Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_location_lockdown/zh_CN/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_location_lockdown Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_location_lockdown/
0f75b33
to
8fe42c4
Compare
/ocabot merge patch |
What a great day to merge this nice PR. Let's do it! |
@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-991-by-rousseldenis-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot merge patch |
Hey, thanks for contributing! Proceeding to merge this for you. |
@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-991-by-rousseldenis-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
What's going on? 🤔 |
pre-commit is stuck on install. Try to solve. /ocabot merge patch |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 4279e5f. Thanks a lot for contributing to OCA. ❤️ |
Standard migration.