Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13.0 mig stock location lockdown #991

Merged

Conversation

manuelregidor
Copy link

Standard migration.

@HaraldPanten
Copy link

@manuelregidor could you recheck pre-commit?

@manuelregidor manuelregidor force-pushed the 13.0-mig-stock_location_lockdown branch from 6da957b to 4db3238 Compare October 20, 2020 06:20
Copy link

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍

Copy link

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@HaraldPanten
Copy link

@OCA/logistics-maintainers could this one be merged?

@rousseldenis
Copy link
Sponsor Contributor

@OCA/logistics-maintainers could this one be merged?

You're in a hurry ? 7 days old. A baby 😃

@rousseldenis rousseldenis added this to the 13.0 milestone Oct 26, 2020
@rousseldenis rousseldenis mentioned this pull request Oct 26, 2020
53 tasks
@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-991-by-rousseldenis-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 26, 2020
Signed-off-by rousseldenis
@OCA-git-bot
Copy link
Contributor

@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-991-by-rousseldenis-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@HaraldPanten
Copy link

Lately, I'm always in a hurry. Thanks @rousseldenis 👍

@rousseldenis
Copy link
Sponsor Contributor

@manuelregidor Could you rebase ?

@manuelregidor manuelregidor force-pushed the 13.0-mig-stock_location_lockdown branch from 4db3238 to 0f75b33 Compare October 27, 2020 08:19
@manuelregidor
Copy link
Author

manuelregidor commented Oct 27, 2020

@rousseldenis Rebase done

@manuelregidor
Copy link
Author

@rousseldenis Travis has failed due to an unrelated travis error. Apparently there is something wrong with a test in module 'stock_vertical_lift_storage_type module', which has no relation with the module I have migrated. How should we proceed? Thank you.

@pedrobaeza
Copy link
Member

We are suffering the same in #998. Either you fix it and put a new PR or put an issue pinging the authors/maintainers of such module. It will be probably a change upstream that has impacted in the module.

@rousseldenis
Copy link
Sponsor Contributor

@pedrobaeza If I have time to test I will objectivate it but I think this is due to odoo/odoo@51b7960

@jgrandguillaume

@HaraldPanten
Copy link

HaraldPanten commented Oct 28, 2020

Here seems to be the fix for the issue #1000

@manuelregidor manuelregidor force-pushed the 13.0-mig-stock_location_lockdown branch from 0f75b33 to 8fe42c4 Compare October 29, 2020 10:14
@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-991-by-rousseldenis-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 30, 2020
Signed-off-by rousseldenis
@OCA-git-bot
Copy link
Contributor

@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-991-by-rousseldenis-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-991-by-rousseldenis-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 30, 2020
Signed-off-by rousseldenis
@OCA-git-bot
Copy link
Contributor

@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-991-by-rousseldenis-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@HaraldPanten
Copy link

What's going on? 🤔

@rousseldenis
Copy link
Sponsor Contributor

pre-commit is stuck on install. Try to solve.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-991-by-rousseldenis-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6a162cf into OCA:13.0 Nov 2, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4279e5f. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 13.0-mig-stock_location_lockdown branch November 2, 2020 15:05
CarlosRoca13 pushed a commit to Tecnativa/stock-logistics-warehouse that referenced this pull request Aug 16, 2021
Signed-off-by rousseldenis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet