Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] stock_orderpoint_generator: Migration to 13.0 #998

Merged
merged 24 commits into from Nov 25, 2020

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Oct 27, 2020

Please @joao-p-marques review it.

@Tecnativa TT25953

Cyril Gaudin and others added 23 commits October 27, 2020 12:09
…#258)

And improve the wording

* Add an option to automatically generate rules

When a product variant is created with a (or several) rule template(s), it
automatically generates (on the fly) the corresponding rule(s). When a rule template
is modified, it automatically updates the existing rules of the linked
products (it uses the mechanism in place, disable the old and create a
fresh one). The latter update is done by a cron because it might take a
long time to update all the products reordering rules.

* Add documentation

* Copy orderpoint views to orderpoint templates

Unfortunately we cannot rely on the possibility to copy a view with
"inherit_id" + "mode=primary" in Odoo 9.0 in this use case (precisely
with a model that is a "copy by prototype").

The explanation:

We "copy by prototype" the model "stock.warehouse.orderpoint" to a new
"stock.warehouse.orderpoint.template" model (with both _inherit and
different _name). Before this commit, we were reusing the
stock.warehouse.orderpoint's views, just making the changes needed for
the templates. Thing is: when a third (unrelated) addon adds a column on
the model, the ORM doesn't add the column in the
stock.warehouse.orderpoint.template model. So the templates' views
complains about this unexisting field.

Therefore, copy-pasting the view ensure that changes on
'stock.warehouse.orderpoint' does not have any side effect on the
templates.

From Odoo 10.0, the "copy by prototype" reports the changes made on the
"prototype" model to the "copy" so we should be able to revert to the
"inherit_id" + "mode=primary" views.
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-11.0/stock-logistics-warehouse-11.0-stock_orderpoint_generator
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-11-0/stock-logistics-warehouse-11-0-stock_orderpoint_generator/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_orderpoint_generator
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_orderpoint_generator/
Currently translated at 50.7% (38 of 75 strings)

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_orderpoint_generator
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_orderpoint_generator/sl/
@victoralmau victoralmau mentioned this pull request Oct 27, 2020
53 tasks
@victoralmau
Copy link
Member Author

Appear some errors in Travis related to addon stock_vertical_lift_storage_type but i don't understand that happened, somebody have any idea about it?

@pedrobaeza
Copy link
Member

Fix for the branch in #1000

@victoralmau victoralmau force-pushed the 13.0-mig-stock_orderpoint_generator branch from 1d36a71 to 42a92be Compare October 28, 2020 11:18
@rousseldenis rousseldenis added this to the 13.0 milestone Oct 30, 2020
@victoralmau victoralmau force-pushed the 13.0-mig-stock_orderpoint_generator branch from 42a92be to 7cdb526 Compare November 3, 2020 08:24
Copy link
Member

@joao-p-marques joao-p-marques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Just some questions and suggestions.

@victoralmau victoralmau force-pushed the 13.0-mig-stock_orderpoint_generator branch from 7cdb526 to 6e73a28 Compare November 16, 2020 07:25
@victoralmau victoralmau force-pushed the 13.0-mig-stock_orderpoint_generator branch from 6e73a28 to d8f72a7 Compare November 16, 2020 07:37
@pedrobaeza
Copy link
Member

@rousseldenis is it OK for you?

Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-998-by-rousseldenis-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 21, 2020
Signed-off-by rousseldenis
@pedrobaeza
Copy link
Member

I'm afraid we have exhausted Travis free build rate, so this won't work. Let's see how do we handle at OCA level.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-998-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d796221 into OCA:13.0 Nov 25, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e3e874d. Thanks a lot for contributing to OCA. ❤️

CarlosRoca13 pushed a commit to Tecnativa/stock-logistics-warehouse that referenced this pull request Aug 16, 2021
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet