Stock ownership availability rules #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For our purposes, no owner behaves the same way as company owner.
This requires a pre init hook for installation and a create().
lepistone
force-pushed
the
stock_ownership_availability_rules
branch
from
d1b4556
to
d226477
Compare
| @@ -0,0 +1,7 @@ | |||
| Stock Ownership Availability Rules | |||
| ================================== | |||
|
|
|||
There was a problem hiding this comment.
Can you please explain the purpose of the module?
lepistone
changed the title
These tests are not necessary anymore, because the owner of the quant is now required. A separate test to check that default is already in place. Even before, "no owner" and "owned by myself" meant the same thing. The tests were green.
1 task
| # You should have received a copy of the GNU Affero General Public License | ||
| # along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| {'name': 'Stock Ownership Availability Rules', | ||
| 'summary': 'XXX', |
There was a problem hiding this comment.
Can you remove the entry or provide a meaningful summary?
I wrote this code when the owner of quants was not required, so I needed to handle more cases. Now the logic can be simplified. Moreover, If a location has a partner_id, I use that as a definition of "own" stock.
|
@gurneyalex you're right with your "side question": if a location has no partner, and no company (neither is required), what can I use as "own" stock? |
|
@lepistone: sounds good to me. |
|
👍 |
2 tasks
| @@ -0,0 +1,14 @@ | |||
| from openerp import models | |||
|
Apart from missing license header LGTM 👍 |
|
@yvaucher I added the missing headers. Feel free to merge 😸 |
|
Thanks |
yvaucher
added a commit
that referenced
this pull request
Jan 14, 2015
Stock ownership availability rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.