[Fix]stock: owner on picking not propagated on quants (Maintenance Issue: 619854)

[skh-odoo]

Steps to reproduce:
1 Navigate to Settings > Configuration > Warehouse, enable 'manage owner on stock', and enable Technical Features for your user
2. Create a incoming stock picking from partner = Camptocamp, with owner = Luc Maurer of 13 IPads
3. Process the picking
4. Display the IPad product and click on the button on the top right corner saying "13 on hand"

Expected:
in the displayed list, I expect to see 1 line with a quant of 13 units and owner = Camptocamp (the commercial_partner_id of Luc Maurer)

Actual:

there is no owner on the quant.

[skh-odoo]

Pull request created for the Issue #4136

[mart-e]

or False is not needed

[mart-e]

as said @lepistone the view is a different fix so should be done in another commit (each one explaining what is currently fixing)

[mart-e]

extra space

[lepistone]

Thanks for the PR @skh-odoo @mart-e.

Something is not clear to me: we have both owner_id on the picking, and restrict_partner_id on the move. Which one is supposed to be used and when?

The changes to the view seem to add a default value on an invisible field (restrict_partner_id) so if the user adds a move and then enters the owner in the picking, it is not propagated. Since the field is hidden, do we actually need it?

Thanks!

[mart-e]

The reported issue #4136 is fixed in the python code.
@skh-odoo is the xml changes for another issue? Could not find it.
As said Leonardo, it will work only if done is a certain order. Instead of using context hack, maybe we could set the value for restrict_partner_id at the confirmation of the move/validation of picking.

[lepistone]

@mart-e we agree python code fixes #4136 which is owner propagation picking.in -> quant.

The other issue is respecting owner on stock reservation. According to @jco-odoo here odoo-dev@3e26a5d it is not fully implemented.

I accept that, so I developed OCA/stock-logistics-workflow/pull/44: it makes reservation always respect the owner, which I made required on quants (with proper defaults) to avoid the ambiguity of "no owner". The tests of that module should clarify things.

The thing I miss is - as I said - what's the difference between Picking.owner_id and Move.restrict_partner_id. I'm working on another module to specify the owner on sale order lines, and I doubt which field I should fill in the generated picking.

Thanks!

[jco-odoo]

The restrict_partner_id could have been named owner_id. It is to have a similar naming as restrict_lot_id. Somewhere else, I stated that the restrict_partner_id on the move should be the owner of the picking and vice versa, like the owner_id on the pack operation. It is logical to have one picking with only moves of the same owner.

[lepistone]

Thanks for the answer @jco-odoo. In my module (sale_owner_stock_sourcing) I propagate the owner from sale.order.line to the move. If it is meant like you say, I should probably create separate pickings (and procurement groups?) if two sale.order.lines have different owners.

[jco-odoo]

Normally if it is a sale order, the owner is you. The owner is meant for
when your warehouse does only the logistic operations for a third party.
If you get an assignment, you could create the picking immediately with the
correct owner. Or you need to invent a special kind of sale order.

On Tue, Jan 6, 2015 at 4:19 PM, Leonardo Pistone notifications@github.com
wrote:

Thanks for the answer @jco-odoo https://github.com/jco-odoo. In my
module (sale_owner_stock_sourcing) I propagate the owner from
sale.order.line to the move. If it is meant like you say, I should probably
create separate pickings (and procurement groups?) if two sale.order.lines
have different owners.

—
Reply to this email directly or view it on GitHub
#4548 (comment).

[lepistone]

@jco-odoo exactly, the "special kind of sale order" is the "logistic order" we have in the NGO verticalization:

https://github.com/OCA/vertical-ngo/blob/8.0/logistic_order/__openerp__.py#L31-L40

We are handling sale lines with owners separately in

https://github.com/OCA/sale-workflow/pull/89/files

because someone might want to use those for something other than NGOs. There I am just propagating the owner (if any) from the order line to the move (possibly splitting pickings, which is my concern).

[jco-odoo]

The owner should be added in the domain of the _picking_assign method then. That way they can be separated.

[lepistone]

Thanks a lot @jco-odoo, I hadn't found picking_assign yet!

[mart-e]

Merged at 28833f0, thanks
The owner on the stock.move is another fix that should probably be done differently, still a reflexion in progress.

[lepistone]

Hi all, I found a problem with this fix. I opened issue #5165 and PRs: #5166 OCA#158.