Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][17.0] fs_storage: Migration to 17.0 #323

Merged
merged 31 commits into from
Mar 11, 2024

Conversation

john-herholz-dt
Copy link

No description provided.

lmignon and others added 30 commits January 16, 2024 07:34
This addon define a new model 'fs.storage'  used to get access to a filesystem storage (ftp, sftp, s3, azure, ...) through an unified interface provided by the 'fsspec' python library (https://filesystem-spec.readthedocs.io/en/latest)
…dav. It is not possible to specify a tuple in json
Add history for commit included from OCA#285 and the author to the contributors list
Before this change, users with basic access rights was no more able to create an attachment. The problem was caused by the need to access system information to determine in which file system the attachment should be created, when this sensitive information is not accessible to everyone. The change consists of reading this information in sudo to bypass this security restriction in this specific context.
Currently translated at 100.0% (37 of 37 strings)

Translation: storage-16.0/storage-16.0-fs_storage
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_storage/es/
Currently translated at 100.0% (37 of 37 strings)

Translation: storage-16.0/storage-16.0-fs_storage
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_storage/es/
Currently translated at 100.0% (37 of 37 strings)

Translation: storage-16.0/storage-16.0-fs_storage
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_storage/es/
Currently translated at 100.0% (37 of 37 strings)

Translation: storage-16.0/storage-16.0-fs_storage
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_storage/it/
Before the change, reading the options protocol might not be in sync
with the record protocol.
This is particularly the case if the record is save in the middle of editing
as the value resets, which can be quite confusing.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: storage-16.0/storage-16.0-fs_storage
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_storage/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: storage-16.0/storage-16.0-fs_storage
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_storage/
Currently translated at 100.0% (39 of 39 strings)

Translation: storage-16.0/storage-16.0-fs_storage
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_storage/it/
Currently translated at 100.0% (39 of 39 strings)

Translation: storage-16.0/storage-16.0-fs_storage
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_storage/es/
@@ -16,7 +16,7 @@ class TestFSStorageCase(TransactionCase):
def setUpClass(cls):
super().setUpClass()
cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True))
cls.backend: FSStorage = cls.env.ref("fs_storage.default_fs_storage")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this, as I think it is bad practice to get used with starting records with default_ as for example Odoo throws errors if you do this on fields.

Furthermore it is more precise, as this demo fs_storage is not "default", it is "demo".

@gurneyalex
Copy link
Member

/ocabot migration fs_storage

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jan 25, 2024
@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-323-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7baf44c into OCA:17.0 Mar 11, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d8c81bb. Thanks a lot for contributing to OCA. ❤️

@john-herholz-dt john-herholz-dt deleted the 17.0-mig-fs_storage branch March 11, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet