[17.0][MIG] fs_file + fs_image + fs_file_demo: Migration to 17.0 #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 1, 2024
This was referenced Mar 8, 2024
gurneyalex
approved these changes
Mar 11, 2024
|
/ocabot migration fs_file |
|
/ocabot migration fs_file_demo |
|
/ocabot migration fs_image |
lmignon
reviewed
Mar 24, 2024
| [cache_value], | ||
| dirty=False, | ||
| ) | ||
| for record, value in record_values: |
There was a problem hiding this comment.
Why do you remive the call to norecompute? It was there on purpose..
There was a problem hiding this comment.
Hi, it is deprecated: https://github.com/odoo/odoo/blob/17.0/odoo/api.py#L797
|
@nguyenminhchien can you update your PR since #344 is merged? |
Uses the FilUploader component to manage the file selection and save the file content at same time as the model. Prior to this change, the content was saved as soon as it was selected which is not possible on new records
* Defines extension hooks to use to specify the object type to use as field value and the value to pass when updating the attachment. * Fixes onchange
Store your image into an external filesystem
The *url_path*, *url* and *internal_url* properties on the *FSFileValue* object return *None* if the information is not available (instead of *False*).
To avoid 'Duplicate explicit target name' error in the rst files where 2 links reference the same url, we must use the double underscores __ to make the reference anonymous
Currently translated at 78.5% (11 of 14 strings) Translation: storage-16.0/storage-16.0-fs_image Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_image/fr/
Before this change the creation of empty file was not supported. The issue was mainly due to the fact that at create of a FSFileValue instance with a name but without content, the name was no preserved. As result, the insert of the attachement into the DB failed since the name is a required field. If a FSFileValue instance is now created without content but with a name, the name is now preserved on an empty buffer.
Currently translated at 100.0% (11 of 11 strings) Translation: storage-16.0/storage-16.0-fs_file_demo Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_file_demo/es/
Currently translated at 100.0% (11 of 11 strings) Translation: storage-16.0/storage-16.0-fs_file_demo Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_file_demo/it/
nguyenminhchien
force-pushed
the
17.0-mig-fs_file
branch
from
efdf73b
to
2f19161
Compare
updated |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at e6abc02. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: BSRD-747
Depends on: