Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] fs_base_multi_media + fs_product_multi_media: Migration to 17.0 #352

Merged
merged 21 commits into from
May 31, 2024
Merged

[17.0][MIG] fs_base_multi_media + fs_product_multi_media: Migration to 17.0 #352

merged 21 commits into from
May 31, 2024

Conversation

nguyenminhchien
Copy link

@nguyenminhchien nguyenminhchien commented Mar 11, 2024 •
edited

@nguyenminhchien nguyenminhchien mentioned this pull request Mar 11, 2024
Open
14 tasks
@nguyenminhchien nguyenminhchien marked this pull request as ready for review March 11, 2024 02:51
@dreispt
Copy link
Sponsor Member

dreispt commented May 3, 2024

Needs a rebase

@dreispt dreispt added help wanted Extra attention is needed needs fixing labels May 3, 2024
lmignon and others added 20 commits May 6, 2024 09:17
@lmignon @nguyenminhchien
[ADD] fs_product_multi_media: A drop-in replacement of storage_produc…
9c48593 
…t_media

and storage_media
@nguyenminhchien
[UPD] Update fs_base_multi_media.pot
ea930f7
@OCA-git-bot @nguyenminhchien
[BOT] post-merge updates
723b135
@Ivorra78 @nguyenminhchien
Added translation using Weblate (Spanish)
96d4aaf
@Ivorra78 @nguyenminhchien
Translated using Weblate (Spanish)
2141d9a 
Currently translated at 100.0% (25 of 25 strings)

Translation: storage-16.0/storage-16.0-fs_base_multi_media
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_base_multi_media/es/
@mymage @nguyenminhchien
Added translation using Weblate (Italian)
081d11a
@mymage @nguyenminhchien
Translated using Weblate (Italian)
841cec9 
Currently translated at 100.0% (25 of 25 strings)

Translation: storage-16.0/storage-16.0-fs_base_multi_media
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_base_multi_media/it/
@nguyenminhchien
[IMP] fs_base_multi_media: pre-commit auto fixes
aa2d060
@lmignon @nguyenminhchien
[ADD] fs_product_multi_media: A drop-in replacement of storage_produc…
5a1da6d 
…t_media

and storage_media
@lmignon @nguyenminhchien
[IMP] image_tag: Removes dependency on sale module
1447a2b
@nguyenminhchien
[UPD] Update fs_product_multi_media.pot
5402ee2
@OCA-git-bot @nguyenminhchien
[BOT] post-merge updates
7cf6b5d
@lmignon @nguyenminhchien
[FIX] fs_product_multi_media: Sort variant_media_ids by sequence
14b6b3d 
Ensures the variant_media_ids are sorted by sequence and name. Before this
change, the order was random and could change between runs.
@OCA-git-bot @nguyenminhchien
[BOT] post-merge updates
e4e9ad3
@Ivorra78 @nguyenminhchien
Added translation using Weblate (Spanish)
32868fb
@Ivorra78 @nguyenminhchien
Translated using Weblate (Spanish)
5db8bef 
Currently translated at 100.0% (27 of 27 strings)

Translation: storage-16.0/storage-16.0-fs_product_multi_media
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_media/es/
@mymage @nguyenminhchien
Added translation using Weblate (Italian)
e315a56
@mymage @nguyenminhchien
Translated using Weblate (Italian)
1bc739b 
Currently translated at 100.0% (27 of 27 strings)

Translation: storage-16.0/storage-16.0-fs_product_multi_media
Translate-URL: https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_product_multi_media/it/
@nguyenminhchien
[IMP] fs_product_multi_media: pre-commit auto fixes
d4a74b7
@nguyenminhchien
[MIG] fs_base_multi_media: Migration to 17.0
94415c5
@nguyenminhchien nguyenminhchien force-pushed the 17.0-mig-fs_product_multi_media branch from a9d996b to b1dca35 Compare May 6, 2024 02:17
@nguyenminhchien nguyenminhchien force-pushed the 17.0-mig-fs_product_multi_media branch from b1dca35 to 98a8d88 Compare May 6, 2024 02:23
@nguyenminhchien
Copy link
Author

Needs a rebase

updated

@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-352-by-gurneyalex-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 21, 2024
@OCA-git-bot
Merge PR #352 into 17.0
e4d7031 
Signed-off-by gurneyalex
@OCA-git-bot
Copy link
Contributor

@gurneyalex your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-352-by-gurneyalex-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@gurneyalex
Copy link
Member

Merge fail should be fixed by #373

Retrying

@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-352-by-gurneyalex-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 31, 2024
@OCA-git-bot
Merge PR #352 into 17.0
00d882b 
Signed-off-by gurneyalex
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 17.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 17.0-ocabot-merge-pr-352-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a2079b1 into OCA:17.0 May 31, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d2d0d65. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurneyalex gurneyalex gurneyalex approved these changes

Assignees
No one assigned
Labels
help wanted Extra attention is needed merged 🎉 needs fixing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@nguyenminhchien @dreispt @gurneyalex @OCA-git-bot @lmignon @Ivorra78 @mymage