-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][MIG] storage_backend_s3 #36
Conversation
URL computation depends on server env params now hence it makes no sense anymore to store its value. In the past, the url field was used by a controller to lookup for the record which is not the case anymore.
@lmignon good for you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @simahawk
@@ -5,7 +5,7 @@ | |||
{ | |||
"name": "Storage Backend SFTP", | |||
"summary": "Implement SFTP Storage", | |||
"version": "12.0.1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
13?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this module is not migrated yet, it comes from 12 as it is
/ocabot merge |
On my way to merge this fine PR! |
Congratulations, your PR was merged at fbf65df. Thanks a lot for contributing to OCA. ❤️ |
Replaces #26
Includes a merge from 12.0