[12.0][MIG] crm_phonecall_timesheet #261

Tardo · 2019-06-03T09:47:09Z

Some changes:

Now if you change the duration to 0, the timesheet will be deleted.
Added stop button in "logged calls" tree view

cc @Tecnativa

victormmtorres · 2019-06-03T17:39:47Z

@Tardo please make sure rebase all your commits to one.

pedrobaeza · 2019-06-04T08:18:52Z

@rafaelbn @victormmtorres can you check?

crm_phonecall_timesheet/models/crm_lead.py

crm_phonecall_timesheet/models/crm_phonecall.py

pedrobaeza

I don't get exactly what you have made here. Phone calls timesheets should be independent from leads and their timesheets, so all the stuff for converting things seems not needed.

Tardo · 2019-06-05T12:15:58Z

Ok, reverted changes and now follow the original module flow

rafaelbn

Only functional test in runbor 👍

chienandalu

Some remarks

chienandalu · 2019-06-05T13:00:25Z

crm_phonecall_timesheet/views/crm_phonecall_view.xml

@@ -63,8 +70,7 @@
            <notebook>
                <page string="Timesheet">
                    <field name="timesheet_ids"
-                        context="{'default_account_id': analytic_account_id,
-                                  'default_user_id': uid}" />


To keep the original behavior and inheritance:

<field name="timesheet_ids" context="{'tree_view_ref': 'analytic.view_account_analytic_line_tree','default_account_id': analytic_account_id, 'default_user_id': uid}"/>

chienandalu · 2019-06-05T13:02:34Z

crm_phonecall_timesheet/tests/test_crm_phonecall.py

-        self.assertEqual(phonecall.date[:DATE_LENGTH], timesheet.date)
+        self.assertEqual(
+            phonecall.date.strftime(DEFAULT_SERVER_DATE_FORMAT),
+            timesheet.date.strftime(DEFAULT_SERVER_DATE_FORMAT))


use odoo.date_utils, it's more fun :)

date_utils? i will use date objects self.assertEqual(phonecall.date.date(), timesheet.date)

Sure, they're datetime objects now. Anyway, is it redundant the date() method?

phonecall it's an datetime, timesheet it's an 'date'... .date() convert datetime to date.

chienandalu · 2019-06-05T13:08:28Z

crm_phonecall_timesheet/models/crm_phonecall.py

+        AccountAnalitycLineObj = self.env['account.analytic.line']
+        for record in self:
+            timesheet = AccountAnalitycLineObj.search([
+                ('phonecall_id', '=', record.id)])


You dropped this domain filter from the original: ('code', '=', 'phone')

chienandalu · 2019-06-05T13:12:04Z

crm_phonecall_timesheet/README.rst

-  timer when call ends, this will set exactly the time you spent.
+1. Create a phonecall in tree or directly an Opportunity
+2. If you create a phonecall, convert it to opportunity
+3. Set the project (with an analytic account associated)


Change this to fit the real flow

Tardo · 2019-06-05T14:20:46Z

Changes done, except 'date_utils' usage... thanks.

chienandalu

Great! 👍

pedrobaeza

You are still showing the analytic account instead of the project_id. You must put in views project_id field and fill that one and the corresponding analytic account from project in the analytic account.

chienandalu · 2019-06-06T07:52:36Z

You are still showing the analytic account instead of the project_id. You must put in views project_id field and fill that one and the corresponding analytic account from project in the analytic account.

Then the original module was wrong all along, isn't it?

pedrobaeza · 2019-06-06T07:54:38Z

No, it's just that the approach changed on v11: in v10, there were analytic_account_id everywhere. On v11, what determines that is a timesheet is the project_id field. We should reflect this change of approach here in the module.

Currently translated at 100.0% (10 of 10 strings) Translation: hr-timesheet-10.0/hr-timesheet-10.0-crm_phonecall_timesheet Translate-URL: https://translation.odoo-community.org/projects/hr-timesheet-10-0/hr-timesheet-10-0-crm_phonecall_timesheet/it/

Tardo · 2019-06-06T08:43:05Z

Changes done

chienandalu

Tested on runbot after the last changes 👍

Just some comments

chienandalu · 2019-06-06T10:28:14Z

crm_phonecall_timesheet/__manifest__.py

 # Copyright 2015 Antonio Espinosa <antonio.espinosa@tecnativa.com>
 # Copyright 2015 Javier Iniesta <javieria@antiun.com>
 # Copyright 2017 David Vidal <david.vidal@tecnativa.com>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 {
    'name': "CRM Timesheet",
    'category': 'Customer Relationship Management',
-    'version': '10.0.1.0.0',
+    'version': '12.0.1.0.0',
    'depends': [
        'crm_timesheet',


Would it be enough to depend on hr_timesheet

chienandalu · 2019-06-06T10:44:05Z

crm_phonecall_timesheet/views/crm_phonecall_view.xml

                options="{'no_open': True, 'no_create': True}"/>
        </field>
        <field name="description" position="after">
            <notebook>
                <page string="Timesheet">
                    <field name="timesheet_ids"
-                        context="{'default_account_id': analytic_account_id,
-                                  'default_user_id': uid}" />
+                           context="{'tree_view_ref': 'analytic.view_account_analytic_line_tree','default_project_id': project_id, 'default_user_id': uid}"/>


With the last changes, this would be the proper one: hr_timesheet.hr_timesheet_line_tree

crm_phonecall_timesheet/README.rst

Tardo · 2019-06-07T09:11:28Z

@chienandalu changes applied, thanks.

chienandalu · 2019-06-07T09:24:29Z

Great!

pedrobaeza added this to the 12.0 milestone Jun 4, 2019

pedrobaeza reviewed Jun 4, 2019

View reviewed changes

crm_phonecall_timesheet/models/crm_lead.py Outdated Show resolved Hide resolved

pedrobaeza reviewed Jun 4, 2019

View reviewed changes

crm_phonecall_timesheet/models/crm_phonecall.py Outdated Show resolved Hide resolved

pedrobaeza requested changes Jun 4, 2019

View reviewed changes

Tardo force-pushed the 12.0-mig-crm_phonecall_timesheet branch from a6b18c0 to 71b8ed3 Compare June 5, 2019 11:40

rafaelbn approved these changes Jun 5, 2019

View reviewed changes

chienandalu suggested changes Jun 5, 2019

View reviewed changes

Tardo force-pushed the 12.0-mig-crm_phonecall_timesheet branch from 71b8ed3 to 134f30d Compare June 5, 2019 14:19

chienandalu approved these changes Jun 5, 2019

View reviewed changes

Tardo force-pushed the 12.0-mig-crm_phonecall_timesheet branch from 134f30d to 1cf99c9 Compare June 5, 2019 15:08

pedrobaeza requested changes Jun 6, 2019

View reviewed changes

chienandalu and others added 2 commits June 6, 2019 10:41

[MIG] crm_phonecall_timesheet: Migration to 10.0

7dbc442

Translated using Weblate (Italian)

d63e772

Currently translated at 100.0% (10 of 10 strings) Translation: hr-timesheet-10.0/hr-timesheet-10.0-crm_phonecall_timesheet Translate-URL: https://translation.odoo-community.org/projects/hr-timesheet-10-0/hr-timesheet-10-0-crm_phonecall_timesheet/it/

Tardo force-pushed the 12.0-mig-crm_phonecall_timesheet branch from 1cf99c9 to 5e793b8 Compare June 6, 2019 08:42

Tardo force-pushed the 12.0-mig-crm_phonecall_timesheet branch from 5e793b8 to 6dbf61d Compare June 6, 2019 09:16

chienandalu reviewed Jun 6, 2019

View reviewed changes

[MIG] crm_phonecall_timesheet: Migration to 12.0

ce87f82

Tardo force-pushed the 12.0-mig-crm_phonecall_timesheet branch from 6dbf61d to ce87f82 Compare June 7, 2019 09:10

pedrobaeza approved these changes Jun 7, 2019

View reviewed changes

OCA-git-bot added the approved label Jun 7, 2019

pedrobaeza merged commit be46157 into OCA:12.0 Jun 7, 2019

pedrobaeza deleted the 12.0-mig-crm_phonecall_timesheet branch June 7, 2019 12:16

OCA-git-bot mentioned this pull request Jun 7, 2019

Migration to version 12.0 #135

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.0][MIG] crm_phonecall_timesheet #261

[12.0][MIG] crm_phonecall_timesheet #261

Tardo commented Jun 3, 2019 •

edited

Loading

victormmtorres commented Jun 3, 2019

pedrobaeza commented Jun 4, 2019

pedrobaeza left a comment

Tardo commented Jun 5, 2019

rafaelbn left a comment

chienandalu left a comment

chienandalu Jun 5, 2019

chienandalu Jun 5, 2019

Tardo Jun 5, 2019

chienandalu Jun 5, 2019

Tardo Jun 5, 2019

chienandalu Jun 5, 2019

chienandalu Jun 5, 2019

chienandalu Jun 5, 2019

Tardo commented Jun 5, 2019

chienandalu left a comment

pedrobaeza left a comment

chienandalu commented Jun 6, 2019

pedrobaeza commented Jun 6, 2019

Tardo commented Jun 6, 2019

chienandalu left a comment

chienandalu Jun 6, 2019

chienandalu Jun 6, 2019

Tardo commented Jun 7, 2019

chienandalu commented Jun 7, 2019

[12.0][MIG] crm_phonecall_timesheet #261

[12.0][MIG] crm_phonecall_timesheet #261

Conversation

Tardo commented Jun 3, 2019 • edited Loading

victormmtorres commented Jun 3, 2019

pedrobaeza commented Jun 4, 2019

pedrobaeza left a comment

Choose a reason for hiding this comment

Tardo commented Jun 5, 2019

rafaelbn left a comment

Choose a reason for hiding this comment

chienandalu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tardo commented Jun 5, 2019

chienandalu left a comment

Choose a reason for hiding this comment

pedrobaeza left a comment

Choose a reason for hiding this comment

chienandalu commented Jun 6, 2019

pedrobaeza commented Jun 6, 2019

Tardo commented Jun 6, 2019

chienandalu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tardo commented Jun 7, 2019

chienandalu commented Jun 7, 2019

Tardo commented Jun 3, 2019 •

edited

Loading