Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] hr_timesheet_sheet_attendance #669

Merged
merged 20 commits into from
May 10, 2024
Merged

[16.0][MIG] hr_timesheet_sheet_attendance #669

merged 20 commits into from
May 10, 2024

Conversation

LauraCForgeFlow
Copy link

Standard migration

bizzappdev and others added 19 commits April 10, 2024 13:46
@bizzappdev @LauraCForgeFlow
[ADD] HR Timesheet sheet attendance (OCA#169)
bbbf98a
@LauraCForgeFlow
[MIG] hr_timesheet_sheet_attendance: Migration to 12.0
1f69762
@LauraCForgeFlow
[MIG] hr_timesheet_sheet_attendance: Address PR comments
6c73532
@wpichler @LauraCForgeFlow
[FIX] Fix for issue OCA#382
ca97fb9
@chienandalu @LauraCForgeFlow
[FIX] hr_timesheet_sheet_attendance: permissions
4efaa3f 
Manual attendance users (`hr_attendance.group_hr_attendance`) aren't
supposed to be able to modify their own attendances times. So we raise
the permission to Attendance Officer.

TT30141
@LauraCForgeFlow
[IMP] hr_timesheet_sheet_attendance: black, isort, prettier
a71d594
@LauraCForgeFlow
[MIG] hr_timesheet_sheet_attendance: Migration to 14.0
01526e5
@oca-travis @LauraCForgeFlow
[UPD] Update hr_timesheet_sheet_attendance.pot
70fdbe9
@OCA-git-bot @LauraCForgeFlow
[UPD] README.rst
4923044
@mymage @LauraCForgeFlow
Added translation using Weblate (Italian)
496d79f
@mymage @LauraCForgeFlow
Translated using Weblate (Italian)
278b9e4 
Currently translated at 100.0% (19 of 19 strings)

Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_sheet_attendance
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_sheet_attendance/it/
@douglascstd @LauraCForgeFlow
Added translation using Weblate (Portuguese (Brazil))
69a8b07
@douglascstd @LauraCForgeFlow
Translated using Weblate (Portuguese (Brazil))
7c16e00 
Currently translated at 100.0% (19 of 19 strings)

Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_sheet_attendance
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_sheet_attendance/pt_BR/
@mymage @LauraCForgeFlow
Translated using Weblate (Italian)
83a82c9 
Currently translated at 100.0% (19 of 19 strings)

Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_sheet_attendance
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_sheet_attendance/it/
@mymage @LauraCForgeFlow
Translated using Weblate (Italian)
63aa66d 
Currently translated at 100.0% (19 of 19 strings)

Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_sheet_attendance
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_sheet_attendance/it/
@mymage @LauraCForgeFlow
Translated using Weblate (Italian)
2069dd0 
Currently translated at 100.0% (19 of 19 strings)

Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_sheet_attendance
Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_sheet_attendance/it/
@JasminSForgeFlow @LauraCForgeFlow
[MIG] hr_timesheet_sheet_attendance: Migration to 15.0
fd66ea6
@LauraCForgeFlow
[IMP] hr_timesheet_sheet_attendance: pre-commit stuff
3aea5fc
@LauraCForgeFlow
[MIG] hr_timesheet_sheet_attendance: Migration to 16.0
f74bc43
MiquelRForgeFlow
MiquelRForgeFlow approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LauraCForgeFlow LauraCForgeFlow mentioned this pull request Apr 10, 2024
Open
1 task
MarinaAForgeFlow
MarinaAForgeFlow approved these changes Apr 11, 2024
View reviewed changes
Copy link

@MarinaAForgeFlow MarinaAForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

edlopen
edlopen approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@edlopen edlopen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dreispt
Copy link
Sponsor Member

dreispt commented May 10, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-669-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8ce99a5 into OCA:16.0 May 10, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d65d319. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 16.0-mig-hr_timesheet_sheet_attendance branch May 13, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@edlopen edlopen edlopen approved these changes

@MarinaAForgeFlow MarinaAForgeFlow MarinaAForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet