Add module logistics_requisition_donation #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvaucher
force-pushed
the
8.0-add-logistics_requisition_donation
branch
5 times, most recently
from
66a8278
to
a4f1707
Compare
|
Tell me if I can help with the red build @yvaucher. |
|
I edited my last comment because I messed up with another PR's travis build. |
yvaucher
force-pushed
the
8.0-add-logistics_requisition_donation
branch
from
a4f1707
to
4a36b30
Compare
|
Rebased on top of #92 |
yvaucher
force-pushed
the
8.0-add-logistics_requisition_donation
branch
from
7f8cf60
to
b0931b2
Compare
|
|
||
| @api.onchange('procurement_method') | ||
| def onchange_source_type_warning(self): | ||
| if self.procurement_method: |
There was a problem hiding this comment.
To fix
not in ('wh_dispatch', 'other')
2 tasks
yvaucher
force-pushed
the
8.0-add-logistics_requisition_donation
branch
from
b0931b2
to
cb78ae2
Compare
yvaucher
force-pushed
the
8.0-add-logistics_requisition_donation
branch
from
cb78ae2
to
c5269e9
Compare
yvaucher
force-pushed
the
8.0-add-logistics_requisition_donation
branch
from
c5269e9
to
bb62a9f
Compare
|
👍 LGTM |
| :params line: browse record of origin requistion.line | ||
| :params agreement: browse record of origin agreement | ||
| :params qty: quantity to be set on source line | ||
| :param self: record set of origin requistion.line |
There was a problem hiding this comment.
A detail, but I wouldn't document things that are not specific to this method like self.
|
|
||
| if not agreement.product_id.id == self.product_id.id: |
There was a problem hiding this comment.
Maybe the comparison would work on the records without .id ?
Logic is moved on logistic_requisition module and method are simplified with a bit of API v8.0 This change intends to allow to inherit from auto creation of source without having to depends on framework_agreement_sourcing
yvaucher
force-pushed
the
8.0-add-logistics_requisition_donation
branch
from
bb62a9f
to
7cc3635
Compare
|
@lepistone fixed few things according to your remarks |
|
Great! I'm merging when green. |
lepistone
added a commit
that referenced
this pull request
Jan 6, 2015
…nation Add module logistics_requisition_donation
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is based on (includes other PR commits)