Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf issue with web_m2x_options #615

Closed
hparfr opened this issue May 2, 2017 · 2 comments
Closed

Perf issue with web_m2x_options #615

hparfr opened this issue May 2, 2017 · 2 comments

Comments

@hparfr
Copy link
Contributor

hparfr commented May 2, 2017 •
edited
Loading

Hello,

Steps to reproduce:

On a clean base, create a new partner, in Company field enter one character then enter another one, then another one.
6 requests are sent

  • name_search (3 times)
  • check_access_rights (3 times)

Expected:
4 requets:

  • name_search (3 times)
  • check_access_rights (1 time)

Depending of the config set, there can be one more extraenous requests after each key press
https://github.com/OCA/web/blob/8.0/web_m2x_options/static/src/js/form.js#L113

Before working on a patch, Is there a reason why this kind of work are processed client side ?

Ping @codingforfun
@pedrobaeza
Copy link
Member

Are you sure there's not the same number of calls without the module? If not, then the query for the disable_quick_create field should be performed in another function that it's called only once.

@hparfr hparfr mentioned this issue May 29, 2017
Merged
@hparfr
Copy link
Contributor Author

hparfr commented May 30, 2017

Yes the module add these calls.

In pr #641 the results from the first calls are reused afterwards.

pedrobaeza pushed a commit that referenced this issue May 30, 2017
@hparfr @pedrobaeza
[IMP] web_m2x_options: Perf issue #615 (#641)
b03164d 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.

Closes #615
jesusVMayor added a commit to Comunitea/web that referenced this issue May 30, 2017
@jesusVMayor
[IMP] web_m2x_options: Perf issue OCA#615
57774b6 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
jesusVMayor added a commit to Comunitea/web that referenced this issue May 30, 2017
@jesusVMayor
[IMP] web_m2x_options: Perf issue OCA#615
301c59f 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
jesusVMayor added a commit to Comunitea/web that referenced this issue May 30, 2017
@jesusVMayor
[IMP] web_m2x_options: Perf issue OCA#615
c9a94e6 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
pedrobaeza added a commit that referenced this issue May 31, 2017
@pedrobaeza
Merge pull request #644 from Comunitea/10.0-fix-web_m2x_check_access
37b659d 
[fix]web_m2x_options: creation access rules / Perf issue #615
ernestotejeda pushed a commit to ernestotejeda/web that referenced this issue Jun 11, 2018
@jesusVMayor @ernestotejeda
[IMP] web_m2x_options: Perf issue OCA#615
2b6065c 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
yajo pushed a commit to ernestotejeda/web that referenced this issue Jun 13, 2018
@jesusVMayor @yajo
[IMP] web_m2x_options: Perf issue OCA#615
7b530c4 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
yajo pushed a commit to ernestotejeda/web that referenced this issue Jun 13, 2018
@jesusVMayor @yajo
[IMP] web_m2x_options: Perf issue OCA#615
ac07c03 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
yajo pushed a commit to ernestotejeda/web that referenced this issue Jun 13, 2018
@jesusVMayor @yajo
[IMP] web_m2x_options: Perf issue OCA#615
8063102 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
ernestotejeda pushed a commit to ernestotejeda/web that referenced this issue Jun 17, 2018
@jesusVMayor @ernestotejeda
[IMP] web_m2x_options: Perf issue OCA#615
8d3abcc 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
pedrobaeza pushed a commit to ernestotejeda/web that referenced this issue Jun 21, 2018
@jesusVMayor @pedrobaeza
[IMP] web_m2x_options: Perf issue OCA#615
12be6d2 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
ovnicraft pushed a commit to ovnicraft/web that referenced this issue Jan 3, 2019
@jesusVMayor @admin-schreurs
[IMP] web_m2x_options: Perf issue OCA#615
857cedd 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
tschanzt pushed a commit to camptocamp/web that referenced this issue Jun 19, 2019
@jesusVMayor
[IMP] web_m2x_options: Perf issue OCA#615
ae6985f 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
jeroenev pushed a commit to jeroenev/web that referenced this issue Oct 2, 2019
@jesusVMayor
[IMP] web_m2x_options: Perf issue OCA#615
16b259b 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
dsolanki-initos pushed a commit to initOS/web that referenced this issue Oct 26, 2020
@jesusVMayor @dsolanki-initos
[IMP] web_m2x_options: Perf issue OCA#615
0aa4bd2 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
dsolanki-initos pushed a commit to initOS/web that referenced this issue Dec 18, 2020
@jesusVMayor @dsolanki-initos
[IMP] web_m2x_options: Perf issue OCA#615
c7beee4 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
dsolanki-initos pushed a commit to initOS/web that referenced this issue Mar 2, 2021
@jesusVMayor @dsolanki-initos
[IMP] web_m2x_options: Perf issue OCA#615
207782f 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
goliveirab pushed a commit to vauxoo-dev/web that referenced this issue Nov 5, 2021
@jesusVMayor @goliveirab
[IMP] web_m2x_options: Perf issue OCA#615
26615b1 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
anothingguy pushed a commit to anothingguy/web that referenced this issue Mar 8, 2023
@jesusVMayor @anothingguy
[IMP] web_m2x_options: Perf issue OCA#615
9048455 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
CRogos pushed a commit to c4a8-odoo/module-oca-web that referenced this issue Mar 23, 2023
@jesusVMayor
[IMP] web_m2x_options: Perf issue OCA#615
1f50098 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
Ammar-OSI pushed a commit to ursais/web that referenced this issue Mar 15, 2024
@jesusVMayor @Ammar-OSI
[IMP] web_m2x_options: Perf issue OCA#615
579faef 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
siemenv pushed a commit to siemenv/web that referenced this issue Mar 25, 2024
@jesusVMayor @siemenv
[IMP] web_m2x_options: Perf issue OCA#615
79226dc 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
dynapps pushed a commit to DynAppsNV/web that referenced this issue Jun 13, 2024
@jesusVMayor @dyngnijs
[IMP] web_m2x_options: Perf issue OCA#615
f0e4041 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
mohs8421 pushed a commit to mohs8421/oca-web that referenced this issue Jun 17, 2024
@jesusVMayor @mohs8421
[IMP] web_m2x_options: Perf issue OCA#615
965d703 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
mohs8421 pushed a commit to mohs8421/oca-web that referenced this issue Jun 18, 2024
@jesusVMayor @mohs8421
[IMP] web_m2x_options: Perf issue OCA#615
9359b99 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
dynapps pushed a commit to DynAppsNV/web that referenced this issue Jun 19, 2024
@jesusVMayor @dyngnijs
[IMP] web_m2x_options: Perf issue OCA#615
b7ec491 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
dynapps pushed a commit to DynAppsNV/web that referenced this issue Jul 22, 2024
@jesusVMayor @dyngnijs
[IMP] web_m2x_options: Perf issue OCA#615
8a51e7b 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
dynapps pushed a commit to DynAppsNV/web that referenced this issue Jul 22, 2024
@jesusVMayor @dyngnijs
[IMP] web_m2x_options: Perf issue OCA#615
3432341 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
manuelregidor pushed a commit to sygel-technology/web that referenced this issue Jul 22, 2024
@jesusVMayor @manuelregidor
[IMP] web_m2x_options: Perf issue OCA#615
673c8d4 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
manuelregidor pushed a commit to sygel-technology/web that referenced this issue Jul 24, 2024
@jesusVMayor @manuelregidor
[IMP] web_m2x_options: Perf issue OCA#615
155c881 
* fix unecessary calls

Do check_access_rights and disable_quick_create calls only once per field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pedrobaeza @hparfr