Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two new functionalities to m2x dialogs #120

Merged
merged 11 commits into from
Aug 20, 2015
Merged

Add two new functionalities to m2x dialogs #120

merged 11 commits into from
Aug 20, 2015

Conversation

ecino
Copy link

@ecino ecino commented Apr 17, 2015

Add two new options in module web_m2x_options :

  • search_more : option to always show the "Search more..." in one2many dialogs, even if all search results are displayed.
  • field_color : option for changing the color of listed records based on field's values

Other changes :

  • Added option m2o_dialog in system parameters
  • Added function to check either for "True" or "true" values

@pedrobaeza
Copy link
Member

Interesting changes! Can you add also a system parameter to make "Search more..." default for all m2x fields?

Do you plan to migrate these changes to 8.0?

@ecino
Copy link
Author

ecino commented Apr 17, 2015

Currently, branch 7.0 does not support system parameters so we didn't include this option. It could be added after #114 is merged.

It would be great to migrate for version 8.0 but it is not our priority at the moment.

@pedrobaeza
Copy link
Member

OK, I have merged #114, so you need to rebase and adjust conflicts (sorry for that), and you can implement the feature I mention. About 8.0 migration of new features, I have added an issue to track and remember this: #121.

@ecino
Copy link
Author

ecino commented Apr 17, 2015

@pedrobaeza Added system parameter option.

I noticed that parameters format are not consistent between views and system parameters. In the xml, a boolean option is set with lowercase (true/false), and in system parameters it is set with a capital letter (True/False). I followed this convention but wouldn't it be better to standardize the format ?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 35.83% when pulling f304d98 on CompassionCH:7.0 into 1b25de8 on OCA:7.0.

@pedrobaeza
Copy link
Member

Yeah, you're right. Some standarization or cast to boolean would be desirable.

@legalsylvain legalsylvain added this to the 7.0 milestone May 6, 2015
@ecino
Copy link
Author

ecino commented Jun 3, 2015

I added a function to check for "True"/"true" values in javascript.
I also added the missing m2o_dialog option in system parameters.

@pedrobaeza
Copy link
Member

I'm afraid the rebase is not correct. You have changes in web_advanced_filters module an in .travis.yml.

@ecino
Copy link
Author

ecino commented Jun 3, 2015

Ok, I corrected the pull request.

@pedrobaeza
Copy link
Member

It seems good now, but I was not able to try on runbot, so you have my 👍 (code review).

@ecino
Copy link
Author

ecino commented Jun 16, 2015

Anyone else for a review ? We may soon start porting this for V8.

@njeudy
Copy link

njeudy commented Jun 19, 2015

+1 I just test it on V7 :) thanks for improvement.

I will try to port this to v8 :)

@njeudy
Copy link

njeudy commented Jun 19, 2015

👍

@ecino
Copy link
Author

ecino commented Aug 20, 2015

We are currently porting it to v8. What is the status of this one, could we merge it ?

@pedrobaeza
Copy link
Member

Yeah, it can be merged with the 2 approvals and more than 5 days.

pedrobaeza added a commit that referenced this pull request Aug 20, 2015
Add two new functionalities to m2x dialogs
@pedrobaeza pedrobaeza merged commit 506f2cc into OCA:7.0 Aug 20, 2015
leemannd pushed a commit to camptocamp/web that referenced this pull request May 29, 2018
DT-71: Simplify usage of depiltech payment mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants