-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add two new functionalities to m2x dialogs #120
Conversation
Interesting changes! Can you add also a system parameter to make "Search more..." default for all m2x fields? Do you plan to migrate these changes to 8.0? |
Currently, branch 7.0 does not support system parameters so we didn't include this option. It could be added after #114 is merged. It would be great to migrate for version 8.0 but it is not our priority at the moment. |
@pedrobaeza Added system parameter option. I noticed that parameters format are not consistent between views and system parameters. In the xml, a boolean option is set with lowercase (true/false), and in system parameters it is set with a capital letter (True/False). I followed this convention but wouldn't it be better to standardize the format ? |
Yeah, you're right. Some standarization or cast to boolean would be desirable. |
I added a function to check for "True"/"true" values in javascript. |
I'm afraid the rebase is not correct. You have changes in web_advanced_filters module an in .travis.yml. |
Ok, I corrected the pull request. |
It seems good now, but I was not able to try on runbot, so you have my 👍 (code review). |
Anyone else for a review ? We may soon start porting this for V8. |
+1 I just test it on V7 :) thanks for improvement. I will try to port this to v8 :) |
👍 |
We are currently porting it to v8. What is the status of this one, could we merge it ? |
Yeah, it can be merged with the 2 approvals and more than 5 days. |
Add two new functionalities to m2x dialogs
DT-71: Simplify usage of depiltech payment mode
Add two new options in module web_m2x_options :
Other changes :