Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] pre-commit update #1499

Merged
merged 2 commits into from
Jan 30, 2020
Merged

[IMP] pre-commit update #1499

merged 2 commits into from
Jan 30, 2020

Conversation

yajo
Copy link
Member

@yajo yajo commented Jan 24, 2020 •
edited
Loading

@OCA-git-bot
Copy link
Contributor

Hi @LoisRForgeFlow, @Tardo,
some modules you are maintaining are being modified, check this out!

@yajo yajo self-assigned this Jan 24, 2020
@yajo yajo added this to the 13.0 milestone Jan 24, 2020
@pedrobaeza
Copy link
Member

Please update with recently merged module.

@yajo
Copy link
Member Author

yajo commented Jan 27, 2020

WIP until OCA/maintainer-quality-tools#630 is merged.

@yajo yajo mentioned this pull request Jan 28, 2020
Merged
Tardo
Tardo approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@Tardo Tardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 For my taste, in some points it makes the code difficult to read but in general it improves it.

@yajo
Copy link
Member Author

yajo commented Jan 30, 2020

OK, let me use my PSC superpowers to merge my own PR for once, so we stop races with PRs being merged without this.

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-1499-by-Yajo-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 30, 2020
@OCA-git-bot
Merge PR #1499 into 13.0
dfe79df 
Signed-off-by Yajo
@OCA-git-bot
Copy link
Contributor

@yajo your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-1499-by-Yajo-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@yajo
Copy link
Member Author

yajo commented Jan 30, 2020

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-1499-by-Yajo-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 30, 2020
@OCA-git-bot
Merge PR #1499 into 13.0
b6f3f44 
Signed-off-by Yajo
Jairo Llopis added 2 commits January 30, 2020 10:52
[IMP] pre-commit update
6d97123 
Implement changes from OCA/maintainer-quality-tools#618, OCA/maintainer-quality-tools#628 and OCA/maintainer-quality-tools#630.

@Tecnativa TT20357

squash! [IMP] pre-commit update
[IMP] pre-commit run after update
77b09d5 
Includes some manual fixes to silent ESLint warnings.
@yajo
Copy link
Member Author

yajo commented Jan 30, 2020

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-1499-by-Yajo-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 30, 2020
@OCA-git-bot
Merge PR #1499 into 13.0
2039d74 
Signed-off-by Yajo
@OCA-git-bot OCA-git-bot merged commit 77b09d5 into OCA:13.0 Jan 30, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4911b0c. Thanks a lot for contributing to OCA. ❤️

@simahawk simahawk mentioned this pull request Jan 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tardo Tardo Tardo approved these changes

Assignees

@yajo yajo

Labels
enhancement merged 🎉 work in progress
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@yajo @OCA-git-bot @pedrobaeza @Tardo