-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] web_listview_range_select #2355
[16.0][MIG] web_listview_range_select #2355
Conversation
[FIX] Firefox shift click [REM] Removed unnecessary configure section [ADD] Roadmap with new features
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-15.0/web-15.0-web_listview_range_select Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_listview_range_select/
<?xml version="1.0" encoding="UTF-8" ?> | ||
<templates xml:space="preserve"> | ||
<t t-inherit="web.ListRenderer.RecordRow" t-inherit-mode="extension"> | ||
<xpath expr="//tr[@class='o_data_row']/td/CheckBox" position="replace"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of replacing the CheckBox
, can't you just add the t-on-click.capture
attribute? This way any eventual attributes customization will be preserved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nileshsheliya please look at this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tarteo Yes, I have updated code accordingly.
web_listview_range_select/static/src/js/web_listview_range_select.esm.js
Show resolved
Hide resolved
"category": "Web", | ||
"author": "Onestein, Odoo Community Association (OCA)", | ||
"author": "Synodica Solutions Pvt. Ltd., Onestein, Odoo Community Association (OCA)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put your company after the original author.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed company position after original author.
this._deselectTable(); | ||
} | ||
}, | ||
CheckBoxSelections(selection) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use camelCase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated method name as camelCase.
a944146
to
1e1c958
Compare
5284e71
to
7438cb2
Compare
/ocabot migration web_listview_range_select |
Hi @nileshsheliya |
@Leonidas-VII I will check and update you. |
@Leonidas-VII The behaviour is same for Odoo 15.0. If you press shift key and click on checkbox column, all the rows between that range is selected well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@astirpe, @tarteo could you update your reviews
@nileshsheliya could you change the commits? squash the yellow and split the migration according to style guide
7438cb2
to
95136e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not working with Firefox.
OK with Edge and Chrome.
Commit history not perfect but OK.
@tarteo could you update your review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed firefox in #2597
Superseded by #2597 |
No description provided.