Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] web_listview_range_select #2355

Closed

Conversation

nileshsheliya
Copy link

No description provided.

@nileshsheliya nileshsheliya changed the title 16.0 mig web listview range select [16.0][MIG] web_listview_range_select Dec 4, 2022
@nileshsheliya nileshsheliya mentioned this pull request Dec 7, 2022
44 tasks
<?xml version="1.0" encoding="UTF-8" ?>
<templates xml:space="preserve">
<t t-inherit="web.ListRenderer.RecordRow" t-inherit-mode="extension">
<xpath expr="//tr[@class='o_data_row']/td/CheckBox" position="replace">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of replacing the CheckBox, can't you just add the t-on-click.capture attribute? This way any eventual attributes customization will be preserved.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nileshsheliya please look at this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarteo Yes, I have updated code accordingly.

"category": "Web",
"author": "Onestein, Odoo Community Association (OCA)",
"author": "Synodica Solutions Pvt. Ltd., Onestein, Odoo Community Association (OCA)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put your company after the original author.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed company position after original author.

this._deselectTable();
}
},
CheckBoxSelections(selection) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use camelCase

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated method name as camelCase.

@nileshsheliya nileshsheliya force-pushed the 16.0-mig-web_listview_range_select branch from a944146 to 1e1c958 Compare March 1, 2023 13:52
@nileshsheliya nileshsheliya force-pushed the 16.0-mig-web_listview_range_select branch from 5284e71 to 7438cb2 Compare March 4, 2023 10:00
@pedrobaeza
Copy link
Member

/ocabot migration web_listview_range_select

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Mar 4, 2023
@Leonidas-VII
Copy link

Hi @nileshsheliya
In functional review, this code doesn't work correctly. I hold shift then try to click on some records, but for the first click, it opens the form view directly
Can you please help me to re-test?

@nikunjantala
Copy link

@Leonidas-VII I will check and update you.

@nileshsheliya
Copy link
Author

@Leonidas-VII The behaviour is same for Odoo 15.0. If you press shift key and click on checkbox column, all the rows between that range is selected well.

Copy link
Contributor

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@astirpe, @tarteo could you update your reviews

@nileshsheliya could you change the commits? squash the yellow and split the migration according to style guide
image

@nileshsheliya nileshsheliya force-pushed the 16.0-mig-web_listview_range_select branch from 7438cb2 to 95136e3 Compare June 24, 2023 08:39
Copy link
Contributor

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not working with Firefox.

OK with Edge and Chrome.
Commit history not perfect but OK.
@tarteo could you update your review?

Copy link
Contributor

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed firefox in #2597

@pedrobaeza
Copy link
Member

Superseded by #2597

@pedrobaeza pedrobaeza closed this Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet