[RFR] in order to work properly, we need to use FieldOne2Many's caching logic #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 code review |
|
It seems to not work according OCA/commission#78 (comment) |
|
Tested with OCA/commission#78 and works great! |
|
👍 |
| }) | ||
| .join(', ') | ||
| ); | ||
| console.log(record.get(column.id + '__display')); |
There was a problem hiding this comment.
thanks, what a beginner's mistake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while looking into OCA/commission#78, I realized this widget is fundamentally flawed because it doesn't apply caching and directly writes into the database. This is different from standard one2many fields, so it should be adapted to use the same caching mechanism.
Mind you that this is basically a rewrite, so test thoroughly before merging.