[MIG] web_dialog_size: Migrate to v9.0 #356
Conversation
|
Thanks 👍 |
| 'category': 'web', | ||
| 'version': '8.0.0.1.0', | ||
| 'version': '9.0.0.1.0', |
|
You have missed the latest 8.0 commits. In concrete, this one: 0578405. You need to follow this guide for the migration: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0, but in this case, as there's only one missing commit, you can only cherry-pick the commit. It's a very important one, because it allows to store the default window size. |
* [IMP] web_dialog_size: Put dialog size expanded by default * [REM] web_popup_large: By duplication of the functionality * [IMP] web_dialog_size: README and contributors * [ADD] configuration parameter for default behavior [FIX] return super's promise [IMP] use fontawesome icons for buttons
bud-e
force-pushed
the
9.0-web_dialog_size
branch
from
19edfbd
to
7f80626
Compare
…efault_maximize parameter
|
👍 (Code review only) |
|
This still misses the latest commit, so please don't merge until then. |
bud-e
force-pushed
the
9.0-web_dialog_size
branch
from
9677093
to
b1d0f12
Compare
|
@pedrobaeza , Thanks. |
| self.$modal.find('.dialog_button_restore').on('click', self.proxy('_restore')); | ||
|
|
||
| new Model('ir.config_parameter').query(['key', 'value']). | ||
| filter([['key', '=', 'web_dialog_size.default_maximize']]).all().then(function(default_maximize) { |
There was a problem hiding this comment.
Why not use the get_param method if ir.config_parameter as in v8? This should be more efficient than querying then filtering.
|
I have tried the module and it works well, and make a quick test with get_param and it didn't work, so it seems the JS API has changed. We can merge this as is. |
No description provided.