-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIG 9.0 support_branding #430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you miss commits from 8.0 - follow https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0 to have them in your PR
|
||
#. On developer mode go to Settings > Technical > Paremeters > System Parameters | ||
#. Configure parameters related with support branding | ||
#. Support branding is showed on left menu and when raises an exception |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something's missing here
@@ -69,6 +85,7 @@ Contributors | |||
|
|||
* Holger Brunn <hbrunn@therp.nl> | |||
* Stefan Rijnhart <srijnhart@therp.nl> | |||
* Angel Moya <odoo@tecnativa.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after you rewrote the js part to v9 api, I'd consider it a serious contribution. As it is, I think this is not warranted
*/ | ||
|
||
openerp.support_branding = function(instance) { | ||
odoo.support_branding = function(instance) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rewrite to v9 api
@hbrunn thanks for yout comments I will rewrite |
When support_branding module is installed and support_branding.release parameter is set, the scrollbar of the menu is moved and the 'Version' indication is not put below the 'Supported by' statement.
6bb54e0
to
af0155e
Compare
@hbrunn I rewrite js, please check it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on runbot, go to the app store, this will trigger an exception. But the exception popup doesn't have the send button, nor the text field to fill in stuff. So it seems you'll have to adapt something there too
var self = this, | ||
ir_config_parameter = new openerp.web.Model('ir.config_parameter'); | ||
ir_config_parameter = new Model('ir.config_parameter'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where do you require Model
? I think you should require web.Model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was fixed
You need to set support email on parameters to get this form and send El 29/9/2016 19:33, "Holger Brunn" notifications@github.com escribió:
|
af0155e
to
d0865bb
Compare
I just filled in an email address, but still no send button on the exception |
I test... send buttons is showed and open system app to send email... but you need to scroll to see that |
OK, tested on Runbot with module test-exceptions.... It's works nice with Undefined type error, not with other error types, I will check it |
Finally I tested with test-exceptions, and is working well. It show email form on ERROR and not show on WARNING. I can do also to show form on warning, but I think that email form is needed for ERROR and not for WARNING, because warning could be use to show information to user. This is the xml that is extended to show email form: https://github.com/OCA/OCB/blob/9.0/addons/web/static/src/xml/base.xml#L31 And this is the record for the warning: https://github.com/OCA/OCB/blob/9.0/addons/web/static/src/xml/base.xml#L22 If it's needed to show email form on warning we only need to add to this record. I think that is not needed for warning, what do you think @hbrunn ? |
@angelmoya Where's the updated code? |
I did not update code, it was right, I only review functionality El 14/10/2016 19:17, "Pedro M. Baeza" notifications@github.com escribió:
|
OK, let's see what @hbrunn says |
I just made @angelmoya's homework and debugged through this, finding that this cannot ever work because of https://github.com/angelmoya/web/blob/d0865bbfa1d0fb79604837ee7db13b567840ecd4/support_branding/static/src/js/support_branding.js#L10 - And then there's still #430 (comment) pending |
superseded by #469 |
No description provided.