Help Online: export improvement #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
👍 Thanks for the improvement. @Cedric-Pigeon, have you seen the debate at #55 ? |
pedrobaeza
added a commit
that referenced
this pull request
Nov 22, 2014
Help Online: export improvement
|
@pedrobaeza |
BT-fgarbely
pushed a commit
to BT-fgarbely/web
that referenced
this pull request
Apr 3, 2018
Syncing from upstream OCA/web (10.0)
leemannd
pushed a commit
to camptocamp/web
that referenced
this pull request
May 29, 2018
Fix account tax xmlid
phongdao
pushed a commit
to phongdao/web
that referenced
this pull request
Jan 17, 2020
backport style v11 to v10
davidtranhp
pushed a commit
to davidtranhp/web
that referenced
this pull request
Feb 7, 2024
backport style v11 to v10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the same image is used on multiple pages, the website module creates only one ir.attachment referenced several times which is optimal.
For help pages, the export feature generates as many xml_id as images. But finally all these xml_id will be linked to the same ir.attachment.
By this way you get several ir.model.data records referencing the same res_id.
This is really unsafe because if you delete one of these images, the odoo update process will delete the ir.attachment and all ir_model_data records linked. So the image will disappear from all pages.
I resolved the problem by using a single xml_id for all duplicates images.
In addition the autobackup feature is not called anymore. This is useless because it should be done in a inherited module. Otherwise it will be executed twice.