[ADD][web_widget_domain_v11] Domain widget backport #672

yajo · 2017-07-12T10:42:39Z

Most code directly copied from upstream Odoo, in the commit before the JS refactor that took place in master.
Some little glue code to make it replace v10's widget.

Below, screenshot of mass mailing addon with this addon installed along with it. Read mode:

Edit mode:

pedrobaeza

This module deserves a better icon, like this one:

There's also a problem on advanced search, because the view is very short, so is there a way to expand the size of the popup when selecting "is in selection"? If not, expand it for all the cases at least:

Please change also the web_advanced_search_x2x README according the changes, and bump its version to 10.0.2.0.0, as it's a big change.

pedrobaeza · 2017-07-12T14:55:45Z

web_widget_domain_v11/README.rst

+
+To use this module, you need to:
+
+#. Install any addon that makes use of the domain widget (i.e.


Instead of this, for being auto-testable, we are going to make the following: change the widget of the domain field of ir.filters. This way, we get that functionality which is very great in this case, and we can test it directly

pedrobaeza · 2017-07-12T15:03:35Z

web_widget_domain_v11/README.rst

+======================
+
+* This addon replaces the built-in ``char_domain`` widget, so it can break
+  compatibility with other addons that use it.


add also / extend it

pedrobaeza · 2017-07-12T15:06:13Z

web_widget_domain_v11/static/src/copied-js/domain_selector_dialog.js

@@ -0,0 +1,47 @@
+odoo.define("web.DomainSelectorDialog", function (require) {


Are these files needed?

There are thousands of JS lines needed. I just copy-pasted all those involved and made sure there was no module name conflict, but honestly I'd prefer not to have to look deeply into each one of them since the life span of this module is going to be so short (just 1 version).

OK, I was talking about the suspicious name copied-js, that it seems to work like a copied-pasted version for references, but not the final JS.

pedrobaeza · 2017-07-12T15:20:11Z

One last thing: translations!

chienandalu

It's so great to have this! 😃

Besides @pedrobaeza comments, I found strange not to be able to use the classic domain filtering like here:

Is it on purpose or am I missing something?

ged-odoo · 2017-07-12T19:39:38Z

good job guys :)

yajo · 2017-07-20T08:45:09Z

It should be ready now.

simahawk

eyeball code review: ok.
functional test: ok.
The only glitch I find is that when you use the widget in a popup (from a related field for instance) the dropdown is cut where the popup ends. But I think this is an issue on the original implementation. Thanks for the port!

yajo · 2017-07-20T09:18:48Z

@simahawk If you can guide me to get to that, I can look at it. 😉 What steps did you follow? Thanks

simahawk · 2017-07-20T10:33:48Z

@yajo this is it:

you have a model (A) w/ a field that relates to another model (B)
you click to edit B and you get its popup form as usual
B has a domain field that uses the widget and here's how it looks like in the popup

so that is fight of scrolling because you have to scroll both on the popup and inside the dropdown of the widget. If I open B form straight (not in a popup) it works smoothly.

yajo · 2017-07-21T07:25:26Z

@simahawk OK I checked it, but it seems like it's good as it is. On one hand I wouldn't know how to properly fix it right now (it's got the proper z-index already AFAICS), but OTOH how would you scroll the main window if there were a modal inside? Just scroll the modal and you can use it as usual, don't you?

simahawk · 2017-07-21T08:09:34Z

@yajo I know. I was not complaining I was just pointing out the issue 😄

Nevertheless if the modal is not that high scrolling is really a pain. The real issue comes not from z-index but from the modal hiding overflow. A simple (?) fix could be: when the dropdown is shown it sets

.modal .modal-dialog .modal-content .modal-body {overflow: visible;}

on the closest modal? Just tried on the fly and it works. Not sure if it has side effects.

yajo · 2017-07-21T10:17:47Z

I tested live with your example code, and the problem is that now the modal does not fit into the screen if it is too big.

You can try on current runbot here pressing edit and then on bank_ids for example.

It turns out somebody already hit this problem, and the new problem from your solution, but still I tested that and it does not seem to work in Odoo, so not sure what else to do. It seems this comment nails it, but I don't want to do that, honestly. 😅

simahawk · 2017-07-21T10:49:19Z

np, we can live with it ATM ;)

pedrobaeza · 2017-07-24T15:13:31Z

One last thing, @yajo: can we have inside the widget domain also the possibility to select the many2one value when the operator is "equal" or "not equal" the same as we have it on the "simple search"?

yajo · 2017-07-25T07:24:35Z

I think that would be a little bit tricky to achieve. Besides, you already have the normal "[not ]equal" filter for that, and I'd prefer not to diverge too much from upstream's domain widget to be able to completely get rid of web_widget_domain_v11 in v11.

pedrobaeza

OK, it's something that we are losing from previous implementation, but we win a lot of other things, so let's merge this.

- Most code directly copied from upstream Odoo, in the commit before the JS refactor that took place in master. - Some little glue code to make it replace v10's widget.

yajo self-assigned this Jul 12, 2017

yajo added the needs review label Jul 12, 2017

yajo added this to the 10.0 milestone Jul 12, 2017

pedrobaeza requested changes Jul 12, 2017

View reviewed changes

pedrobaeza mentioned this pull request Jul 12, 2017

[RFC][master] Use part of the new domain widget on "Add Custom Filter" odoo/odoo#15634

Closed

chienandalu reviewed Jul 12, 2017

View reviewed changes

pedrobaeza mentioned this pull request Jul 19, 2017

[10.0] web_advanced_search_x2x: error while selecting "contains" or "not contains" in a x2x field #676

Closed

simahawk approved these changes Jul 20, 2017

View reviewed changes

pedrobaeza approved these changes Jul 25, 2017

View reviewed changes

yajo added 2 commits July 25, 2017 09:39

[ADD][web_widget_domain_v11] Domain widget backport

b661066

- Most code directly copied from upstream Odoo, in the commit before the JS refactor that took place in master. - Some little glue code to make it replace v10's widget.

[FIX] Compatibilize web_widget_domain_v11 with web_advanced_search_x2x

2cc0d8d

pedrobaeza force-pushed the 10.0-web_widget_domain_v11 branch from 7e06c5c to 2cc0d8d Compare July 25, 2017 07:39

pedrobaeza merged commit 21f50a6 into OCA:10.0 Jul 25, 2017

pedrobaeza deleted the 10.0-web_widget_domain_v11 branch July 25, 2017 07:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD][web_widget_domain_v11] Domain widget backport #672

[ADD][web_widget_domain_v11] Domain widget backport #672

yajo commented Jul 12, 2017

pedrobaeza left a comment

pedrobaeza Jul 12, 2017

pedrobaeza Jul 12, 2017

pedrobaeza Jul 12, 2017

yajo Jul 18, 2017

pedrobaeza Jul 19, 2017

pedrobaeza commented Jul 12, 2017

chienandalu left a comment

ged-odoo commented Jul 12, 2017

yajo commented Jul 20, 2017

simahawk left a comment

yajo commented Jul 20, 2017

simahawk commented Jul 20, 2017

yajo commented Jul 21, 2017

simahawk commented Jul 21, 2017

yajo commented Jul 21, 2017

simahawk commented Jul 21, 2017

pedrobaeza commented Jul 24, 2017

yajo commented Jul 25, 2017

pedrobaeza left a comment


		To use this module, you need to:

		#. Install any addon that makes use of the domain widget (i.e.

		@@ -0,0 +1,47 @@
		odoo.define("web.DomainSelectorDialog", function (require) {

[ADD][web_widget_domain_v11] Domain widget backport #672

[ADD][web_widget_domain_v11] Domain widget backport #672

Conversation

yajo commented Jul 12, 2017

pedrobaeza left a comment

Choose a reason for hiding this comment

pedrobaeza Jul 12, 2017

Choose a reason for hiding this comment

pedrobaeza Jul 12, 2017

Choose a reason for hiding this comment

pedrobaeza Jul 12, 2017

Choose a reason for hiding this comment

yajo Jul 18, 2017

Choose a reason for hiding this comment

pedrobaeza Jul 19, 2017

Choose a reason for hiding this comment

pedrobaeza commented Jul 12, 2017

chienandalu left a comment

Choose a reason for hiding this comment

ged-odoo commented Jul 12, 2017

yajo commented Jul 20, 2017

simahawk left a comment

Choose a reason for hiding this comment

yajo commented Jul 20, 2017

simahawk commented Jul 20, 2017

yajo commented Jul 21, 2017

simahawk commented Jul 21, 2017

yajo commented Jul 21, 2017

simahawk commented Jul 21, 2017

pedrobaeza commented Jul 24, 2017

yajo commented Jul 25, 2017

pedrobaeza left a comment

Choose a reason for hiding this comment