[FIX] web_responsive: Chrome slow scroll #742

lasley · 2017-10-07T15:22:41Z

Test fix. Do not merge until I give the go-ahead please.

mgielissen · 2017-10-07T17:20:44Z

Scrolling works now with Android/Chrome

lasley · 2017-10-07T19:32:34Z

Alright I've applied the same fix without editing the iScroll library, and added a note to the readme to remove the patch once iScroll is updated (this is fixed upstream, but there isn't a new release yet)

MosabWadea · 2017-10-08T05:25:31Z

So I tried this fix but I faced this error, whenever I open the app drawer and close it in the web version:
Uncaught TypeError: Cannot read property 'options' of undefined

https://portal.hobbydistrict.com/web/content/3480-c08c6da/web.assets_backend.js:3427
Traceback:
TypeError: Cannot read property 'options' of undefined
    at HTMLBodyElement.setIScrollProbes (https://portal.hobbydistrict.com/web/content/3480-c08c6da/web.assets_backend.js:3427:2011)
    at HTMLBodyElement.dispatch (https://portal.hobbydistrict.com/web/content/2593-8fb4b90/web.assets_common.js:637:451)
    at HTMLBodyElement.elemData.handle (https://portal.hobbydistrict.com/web/content/2593-8fb4b90/web.assets_common.js:610:173)
    at Object.trigger (https://portal.hobbydistrict.com/web/content/2593-8fb4b90/web.assets_common.js:631:211)
    at HTMLBodyElement.<anonymous> (https://portal.hobbydistrict.com/web/content/2593-8fb4b90/web.assets_common.js:682:147)
    at Function.each (https://portal.hobbydistrict.com/web/content/2593-8fb4b90/web.assets_common.js:370:767)
    at jQuery.fn.init.each (https://portal.hobbydistrict.com/web/content/2593-8fb4b90/web.assets_common.js:358:643)
    at jQuery.fn.init.trigger (https://portal.hobbydistrict.com/web/content/2593-8fb4b90/web.assets_common.js:682:118)
    at HTMLBodyElement.triggerOpenedListeners (https://portal.hobbydistrict.com/web/content/3480-c08c6da/web.assets_backend.js:3424:162)
    at HTMLBodyElement.invokeCallbackOnAnimationEnd (https://portal.hobbydistrict.com/web/content/3480-c08c6da/web.assets_backend.js:3424:889)

I don't think it is from this fix but maybe I did something wrong or inundated library?

P.S. and the fix didn't work on my phone!

pedrobaeza · 2017-10-10T11:57:39Z

I receive this error when clicking on the icon for showing the drawer, and the clicking outside the drawer (on Firefox on my PC):

TypeError: this.iscroll is undefined

http://3306323-742-52282f.runbot3.odoo-community.org/web/content/440-5cf7aed/web.assets_backend.js:3479
Traceback:
setIScrollProbes@http://3306323-742-52282f.runbot3.odoo-community.org/web/content/440-5cf7aed/web.assets_backend.js:3479:1998
dispatch@http://3306323-742-52282f.runbot3.odoo-community.org/web/content/428-7a03819/web.assets_common.js:637:378
add/elemData.handle@http://3306323-742-52282f.runbot3.odoo-community.org/web/content/428-7a03819/web.assets_common.js:610:151
trigger@http://3306323-742-52282f.runbot3.odoo-community.org/web/content/428-7a03819/web.assets_common.js:631:204
trigger/<@http://3306323-742-52282f.runbot3.odoo-community.org/web/content/428-7a03819/web.assets_common.js:682:134
each@http://3306323-742-52282f.runbot3.odoo-community.org/web/content/428-7a03819/web.assets_common.js:370:758
each@http://3306323-742-52282f.runbot3.odoo-community.org/web/content/428-7a03819/web.assets_common.js:358:636
trigger@http://3306323-742-52282f.runbot3.odoo-community.org/web/content/428-7a03819/web.assets_common.js:682:113
triggerOpenedListeners@http://3306323-742-52282f.runbot3.odoo-community.org/web/content/440-5cf7aed/web.assets_backend.js:3476:156
invokeCallbackOnAnimationEnd@http://3306323-742-52282f.runbot3.odoo-community.org/web/content/440-5cf7aed/web.assets_backend.js:3476:880
dispatch@http://3306323-742-52282f.runbot3.odoo-community.org/web/content/428-7a03819/web.assets_common.js:637:378
add/elemData.handle@http://3306323-742-52282f.runbot3.odoo-community.org/web/content/428-7a03819/web.assets_common.js:610:151

lasley · 2017-10-12T16:49:34Z

a8f19a8 should fix the issue - my bad I forgot casing

pedrobaeza · 2017-10-13T04:01:43Z

I have tested and now there's no error and scroll in PCs works correctly, but trying on my Android mobile with Chrome, I still need to make funny moves for scrolling: there's no possibility to tap and hold the finger for scrolling. Can you please check it?

lasley · 2017-10-13T14:49:25Z

I stole my girlfriend's Android for the day - should be able to fix this now

lasley · 2017-10-14T19:59:41Z

Alright this last change was working pretty solid for me yesterday and looks good on Runbot now. Someone want to confirm?

Fix was to upgrade iScroll to the bleeding edge revision, which contains the proper change. It was created 10 months ago and there have been no changes, so I figure it's got to be stable enough.

pedrobaeza

Tried and working. There's still a strange effect on the header bar with the logo and the "< Apps" link, but I think it's not related with this issue.

lasley · 2017-10-14T20:38:48Z

There's still a strange effect on the header bar with the logo and the "< Apps" link, but I think it's not related with this issue.

Is it this?

pedrobaeza · 2017-10-14T22:05:24Z

Yeah, definitively

lasley · 2017-10-14T22:20:54Z

I can't replicate the header issue with the last commit

lasley · 2017-10-14T22:25:29Z

web_responsive/static/src/js/web_responsive.js

-                // 2 == always executes the scroll event except during momentum and bounce.
-                this.iScroll.options.probeType = 2;
+                // 1 == The scroll event is fired only when the scroller is not busy doing its stuff.
+                this.iScroll.options.probeType = 1;


This was actually the fix to the header issue - the transform thing above I realized marginTop was more clear & basically the same.

Hmmm maybe the marginTop isn't the same, I'm reverting that.

pedrobaeza · 2017-10-15T00:00:10Z

Now it's working worst IMO

lasley · 2017-10-16T14:38:23Z

Damn ok I removed the commits from after you mentioned the other header issue & created #756

pedrobaeza · 2017-10-16T14:57:46Z

OK, merging this then. @angelmoya please take this for v11

pedrobaeza · 2017-10-16T14:58:01Z

Should I squash?

* Update to iScoll bleeding edge to fix OCA#741

lasley · 2017-10-16T15:09:23Z

Should I squash?

I went ahead and did it so my GPG is preserved. I'd say we're good for a merge on CI 🍏

[9.0][FIX] web_responsive: Chrome Slow Scrolling

[11.0][FIX] web_responsive: Chrome Slow Scrolling

lasley added bug work in progress labels Oct 7, 2017

lasley added this to the 10.0 milestone Oct 7, 2017

lasley mentioned this pull request Oct 7, 2017

[BUG] web_responsive: App Scroll is Slow on Chrome Mobile #741

Closed

mgielissen mentioned this pull request Oct 7, 2017

very slow scroll on mobile view Openworx/backend_theme#15

Closed

lasley changed the title ~~Fix Chrome slow scroll~~ [FIX] web_responsive: Chrome slow scroll Oct 7, 2017

lasley force-pushed the bugfix/10.0/gh-741-chrome_slow_scroll branch from a23fac8 to 52282f7 Compare October 7, 2017 19:31

lasley added needs review and removed work in progress labels Oct 7, 2017

pedrobaeza requested changes Oct 14, 2017

View reviewed changes

pedrobaeza approved these changes Oct 14, 2017

View reviewed changes

rafaelbn approved these changes Oct 14, 2017

View reviewed changes

lasley commented Oct 14, 2017

View reviewed changes

lasley force-pushed the bugfix/10.0/gh-741-chrome_slow_scroll branch from 29a8f6b to bbc7c1d Compare October 16, 2017 14:37

lasley mentioned this pull request Oct 16, 2017

web_responsive: Header overlapped on scroll #756

Closed

[FIX] web_responsive: Chrome Slow Scrolling

f52d2ab

* Update to iScoll bleeding edge to fix OCA#741

lasley force-pushed the bugfix/10.0/gh-741-chrome_slow_scroll branch from bbc7c1d to f52d2ab Compare October 16, 2017 15:08

lasley merged commit d98d9e4 into OCA:10.0 Oct 16, 2017

lasley deleted the bugfix/10.0/gh-741-chrome_slow_scroll branch October 16, 2017 15:51

lasley mentioned this pull request Oct 16, 2017

[9.0][FIX] web_responsive: Chrome Slow Scrolling #757

Merged

pedrobaeza added a commit that referenced this pull request Oct 17, 2017

Merge pull request #757 from LasLabs/bugfix/9.0/gh-742-backport

4804908

[9.0][FIX] web_responsive: Chrome Slow Scrolling

pedrobaeza added a commit that referenced this pull request Oct 17, 2017

Merge pull request #758 from LasLabs/bugfix/11.0/gh-742-forward-port

96eed3f

[11.0][FIX] web_responsive: Chrome Slow Scrolling

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FIX] web_responsive: Chrome slow scroll #742

[FIX] web_responsive: Chrome slow scroll #742

lasley commented Oct 7, 2017 •

edited

Loading

mgielissen commented Oct 7, 2017

lasley commented Oct 7, 2017

MosabWadea commented Oct 8, 2017 •

edited

Loading

pedrobaeza commented Oct 10, 2017

lasley commented Oct 12, 2017

pedrobaeza commented Oct 13, 2017

lasley commented Oct 13, 2017

lasley commented Oct 14, 2017

pedrobaeza left a comment

lasley commented Oct 14, 2017

pedrobaeza commented Oct 14, 2017

lasley commented Oct 14, 2017

lasley Oct 14, 2017 •

edited

Loading

lasley Oct 14, 2017

pedrobaeza commented Oct 15, 2017

lasley commented Oct 16, 2017

pedrobaeza commented Oct 16, 2017

pedrobaeza commented Oct 16, 2017

lasley commented Oct 16, 2017

[FIX] web_responsive: Chrome slow scroll #742

[FIX] web_responsive: Chrome slow scroll #742

Conversation

lasley commented Oct 7, 2017 • edited Loading

mgielissen commented Oct 7, 2017

lasley commented Oct 7, 2017

MosabWadea commented Oct 8, 2017 • edited Loading

pedrobaeza commented Oct 10, 2017

lasley commented Oct 12, 2017

pedrobaeza commented Oct 13, 2017

lasley commented Oct 13, 2017

lasley commented Oct 14, 2017

pedrobaeza left a comment

Choose a reason for hiding this comment

lasley commented Oct 14, 2017

pedrobaeza commented Oct 14, 2017

lasley commented Oct 14, 2017

lasley Oct 14, 2017 • edited Loading

Choose a reason for hiding this comment

lasley Oct 14, 2017

Choose a reason for hiding this comment

pedrobaeza commented Oct 15, 2017

lasley commented Oct 16, 2017

pedrobaeza commented Oct 16, 2017

pedrobaeza commented Oct 16, 2017

lasley commented Oct 16, 2017

lasley commented Oct 7, 2017 •

edited

Loading

MosabWadea commented Oct 8, 2017 •

edited

Loading

lasley Oct 14, 2017 •

edited

Loading