-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRT][REN] Added module web_hide_db_manager_link, as a port to v8 of web... #89
Conversation
…web_nocreatedb, but with a more descriptive name.
@@ -0,0 +1,661 @@ | |||
GNU AFFERO GENERAL PUBLIC LICENSE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to put LICENSE file here again (it's in root path)
You should remove web_hide_db_manager_link/static/src/img/icon.jpg and web_hide_db_manager_link/static/src/img/icon.png, and move the SVG to static/description. |
Please rebase the branch. |
Changes done. |
You still need to rebase. |
I did this for the second commit:
I get I missed something. Should I delete the project and fork it again, with a single commit+push? |
That's not the way to do a rebase. The sentence is something like |
I get what you mean. Anyway, did the hard way and re-forked and rebuilt my branch. I will close this PR and create a new clean one. |
..._nocreatedb, but with a more descriptive name.