Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRT][REN] Added module web_hide_db_manager_link, as a port to v8 of web... #89

Closed
wants to merge 2 commits into from
Closed

Conversation

alejandrosantana
Copy link

..._nocreatedb, but with a more descriptive name.

…web_nocreatedb, but with a more descriptive name.
@@ -0,0 +1,661 @@
GNU AFFERO GENERAL PUBLIC LICENSE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to put LICENSE file here again (it's in root path)

@pedrobaeza
Copy link
Member

You should remove web_hide_db_manager_link/static/src/img/icon.jpg and web_hide_db_manager_link/static/src/img/icon.png, and move the SVG to static/description.

@pedrobaeza
Copy link
Member

Please rebase the branch.

@alejandrosantana
Copy link
Author

Changes done.

@pedrobaeza
Copy link
Member

You still need to rebase.

@alejandrosantana
Copy link
Author

I did this for the second commit:

git commit -am "..."
git fetch --all
git pull --rebase
git push

I get I missed something. Should I delete the project and fork it again, with a single commit+push?

@pedrobaeza
Copy link
Member

That's not the way to do a rebase. The sentence is something like git --rebase origin/8.0, but it depends on your defined remotes. Maybe you should rebuild again the branch to avoid this difficulties.

@alejandrosantana
Copy link
Author

I get what you mean. Anyway, did the hard way and re-forked and rebuilt my branch. I will close this PR and create a new clean one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants