Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRT][REN] Added module web_hide_db_manager_link, as a port to v8 of web... #92

Merged
merged 4 commits into from
Mar 20, 2015
Merged

[PRT][REN] Added module web_hide_db_manager_link, as a port to v8 of web... #92

merged 4 commits into from
Mar 20, 2015

Conversation

alejandrosantana
Copy link

..._nocreatedb, but with a more descriptive name.
This PR replaces #89

…web_nocreatedb, but with a more descriptive name.

To use this module, you need to:

* As in Odoo v8 templates only live in the database, this module must be installed in each database you want this to be in effect.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a known issue instead the usage.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, fair enough. Chnaging it right now.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Known issues
============

To use this module, you need to:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this sentence

@alejandrosantana
Copy link
Author

Changes done in local. Waiting for review finish to avoid many commits.

@alejandrosantana
Copy link
Author

As review seems finished, pushed changes.

@pedrobaeza
Copy link
Member

👍

parameter in the config file, i think as it is is fine for now.

.. note:: This module probably will not be shown in your module list by default
You should create a menu to see "All modules without filter.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
This seems unecessary. Just remove 'installable: 'False' should fix the problem.
regards.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
'installable' is already set to True. But I see now that that description line is quite confusing.
Maybe I can replace it with:
"In case this module is not immediately shown in your module list, please click on 'Update modules list' menu and remove any filter that may prevent it being shown."
Or maybe just remove the not completely.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forget about it and see the corresponding line in README.rst, in Installation section, as I already have done that change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment is useless, I commented a 'deleted file' ! I'm going to take another coffee.
But yes, I think that your note is useless as this is the normal process for all modules. (update modules list, and remove 'installed' filter'.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coffee is a good friend.
OK for me, I will delete that redundant line in a couple of minutes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@legalsylvain Done removing useless line.

@legalsylvain legalsylvain added this to the 8.0 milestone Mar 9, 2015
* Search by module name "Hide link to database manager in login screen" or by module technical name "*web_hide_db_manager_link*"
* Click install button

In case this module is not shown in your module list by default, click on "Update Module List" and clear any filter to show all modules.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@legalsylvain This is the line already fixing your previous message in the other file. Is this OK?

…plains a standard procedure for updating modules.
@hbrunn
Copy link
Member

hbrunn commented Mar 16, 2015

👍

legalsylvain added a commit that referenced this pull request Mar 20, 2015
[PRT][REN] Added module web_hide_db_manager_link, as a port to v8 of web...
@legalsylvain legalsylvain merged commit a68fb38 into OCA:8.0 Mar 20, 2015
BT-fgarbely pushed a commit to BT-fgarbely/web that referenced this pull request Feb 14, 2018
Syncing from upstream OCA/web (11.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants