[11.0][MIG] web_advanced_search_x2x #984
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and replace company icon
this solves timing problems
I could not find the project on Transifex...
- Use the new domain widget. - Use modules system.
When you were adding a custom filter in a x2x field using "contains", it always became "contains 'false'". Now it is fixed.
Before this patch, when a domain leaf was a string (such as `&`, `|` or `!`), it was being treated as an array. This was leading to errors such as this one:
```
2017-10-19 11:22:01,578 1 ERROR devel odoo.http: Exception during JSON request handling.
Traceback (most recent call last):
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 640, in _handle_exception
return super(JsonRequest, self)._handle_exception(exception)
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 677, in dispatch
result = self._call_function(**self.params)
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 333, in _call_function
return checked_call(self.db, *args, **kwargs)
File "/opt/odoo/custom/src/odoo/odoo/service/model.py", line 101, in wrapper
return f(dbname, *args, **kwargs)
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 326, in checked_call
result = self.endpoint(*a, **kw)
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 935, in __call__
return self.method(*args, **kw)
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 506, in response_wrap
response = f(*args, **kw)
File "/opt/odoo/auto/addons/web/controllers/main.py", line 827, in search_read
return self.do_search_read(model, fields, offset, limit, domain, sort)
File "/opt/odoo/auto/addons/web/controllers/main.py", line 849, in do_search_read
offset=offset or 0, limit=limit or False, order=sort or False)
File "/opt/odoo/custom/src/odoo/odoo/models.py", line 4733, in search_read
records = self.search(domain or [], offset=offset, limit=limit, order=order)
File "/opt/odoo/custom/src/odoo/odoo/models.py", line 1559, in search
res = self._search(args, offset=offset, limit=limit, order=order, count=count)
File "/opt/odoo/custom/src/odoo/odoo/models.py", line 4275, in _search
query = self._where_calc(args)
File "/opt/odoo/custom/src/odoo/odoo/models.py", line 4074, in _where_calc
e = expression.expression(domain, self)
File "/opt/odoo/custom/src/odoo/odoo/osv/expression.py", line 640, in __init__
self.expression = distribute_not(normalize_domain(domain))
File "/opt/odoo/custom/src/odoo/odoo/osv/expression.py", line 289, in distribute_not
elif token in DOMAIN_OPERATORS_NEGATION:
TypeError: unhashable type: 'list'
```
Now they are treated specifically and the problem is fixed.��
|
It has some problems:
I have WIP branch around there, still not working fine too. Let me compare both and I'll try to get best changes from both. 😉 |
|
@yajo I think my last commit fixes the dropdown hidding by prevent click event propagation. |
|
It's finished: #999 Closing in favor of that, please review there. Thanks! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attemp on migrating web_advanced_search_x2x, It wasn't easy, but it's working. I'm sure it can be improved.
The basics of this migration:
- Remove web_domain_v11 dependency
- Adapt how JS manage the fields, which has change a bit since 10.0
I'm open to apply any change in order to improve the code, I'm sure is far to be perfect.