[MIG][REF] web_advanced_search: Rename, refactor, migrate #999

yajo · 2018-07-20T09:43:55Z

Includes [11.0][MIG] web_advanced_search_x2x #984
Git history cleanup
Complete migration to v11
Refactor to use the new v11 decoupled widgets system
Advanced search is now a high-level feature from the filters menu; it simplifies code a lot, and the UX is even better
Split README system
Add fun to ROADMAP
Addon is renamed to web_advanced_search, since it enhaces the searching experience for all kind of fields now

pedrobaeza

Functionally, the only problem I find is with the resulting filter label, putting the technical domain. Isn't any way to put a text description of the filter like in previous versions happen?

pedrobaeza · 2018-07-22T08:41:22Z

web_advanced_search/__manifest__.py

@@ -0,0 +1,27 @@
+# -*- coding: utf-8 -*-
+# Copyright 2015 Therp BV <http://therp.nl>
+# Copyright 2017 Tecnativa - Vicent Cubells


Add your copyright here

pedrobaeza · 2018-07-22T08:42:53Z

web_advanced_search/static/src/js/web_advanced_search_x2x.js

@@ -0,0 +1,283 @@
+/* Copyright 2015 Therp BV <http://therp.nl>


Rename file according module renaming

pedrobaeza · 2018-07-22T08:44:15Z

web_advanced_search/__init__.py

@@ -0,0 +1,3 @@
+# -*- coding: utf-8 -*-


Remove coding

pedrobaeza · 2018-07-22T08:44:21Z

web_advanced_search/__manifest__.py

@@ -0,0 +1,27 @@
+# -*- coding: utf-8 -*-


Remove coding

elicoidal

some details.
Simple tests OK

web_advanced_search/README.rst

+Search for x2x records in advanced search
+=========================================
+
+Standard behavior in advanced search for one2many, many2many and many2one fields is to do a `name_search`. This often is not satisfactionary as you might want to search for other properties. There might also be cases where you don't exactly know what you're searching for, then a list of possible options is necessary too. This module enables you to have a full search view to select the record in question, and either select specific records or select them using a search query of its own.


web_advanced_search/README.rst

+
+To use this module, you need to:
+
+* open the advanced search options in a search view


web_advanced_search/README.rst

+
+To search for properties of linked records (ie invoices for customers with a credit limit higher than X):
+
+* open the advanced search options in a search view


web_advanced_search/README.rst

+Known issues / Roadmap
+======================
+
+* When you use *is in selection* search system and choose a domain, it gets


elicoidal · 2018-07-22T10:17:36Z

web_advanced_search/__manifest__.py

+    "qweb": [
+        'static/src/xml/web_advanced_search.xml',
+    ],
+    "auto_install": False,


no need for the keys with the default values no?

elicoidal · 2018-07-22T10:20:34Z

web_advanced_search/static/src/xml/web_advanced_search.xml

@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!-- Copyright 2017 Jairo Llopis <jairo.llopis@tecnativa.com>


update the date

yajo

Functionally, the only problem I find is with the resulting filter label, putting the technical domain. Isn't any way to put a text description of the filter like in previous versions happen?

Yes, it's in the known issues. We'd need a tool to translate a domain to a human-readable format, which should possibly be upstream, either in odoo itself, or in the module that extends the domain widget, and then used downstream in this addon.

It doesn't seem as a blocker anyway, isn't it? 😇

web_advanced_search/README.rst

+Search for x2x records in advanced search
+=========================================
+
+Standard behavior in advanced search for one2many, many2many and many2one fields is to do a `name_search`. This often is not satisfactionary as you might want to search for other properties. There might also be cases where you don't exactly know what you're searching for, then a list of possible options is necessary too. This module enables you to have a full search view to select the record in question, and either select specific records or select them using a search query of its own.


web_advanced_search/README.rst

+
+To use this module, you need to:
+
+* open the advanced search options in a search view


web_advanced_search/README.rst

+
+To search for properties of linked records (ie invoices for customers with a credit limit higher than X):
+
+* open the advanced search options in a search view


web_advanced_search/README.rst

+Known issues / Roadmap
+======================
+
+* When you use *is in selection* search system and choose a domain, it gets


web_advanced_search/__manifest__.py

+    ],
+    'installable': True,
+    "application": False,
+}


simahawk

code & functional review: LG.
Small things I'd change but not mandatory.

Tested on runbot: the "search more" is a bit glitchy as it closes the filter dropdown but it's something we can live with. Worth to drop a line in roadmap?

simahawk · 2018-08-07T06:36:48Z

web_advanced_search/static/src/js/web_advanced_search.js

+
+        init: function () {
+            this._super.apply(this, arguments);
+            // To make widgets work, we need to a model and an empty record


simahawk · 2018-08-07T06:37:01Z

web_advanced_search/static/src/js/web_advanced_search.js

+    /**
+     * A search field for relational fields.
+     *
+     * It implements and extends the `FieldManagerMixing`, and acts as if it


simahawk · 2018-08-07T06:49:34Z

web_advanced_search/static/src/js/web_advanced_search.js

+                    }
+                });
+            // Create dummy record with only the field the user is searching
+            var params = {


I'd move this to a separated function

I have left this as it was. Thinking about it, it's only done once at init time, and calling it again could produce some problems, so it seems legit to not do a method about it IMHO.

I fixed your other comments though.

yajo · 2018-08-13T10:33:35Z

WIP until I include fixes for @simahawk's suggestions and I backport human-readable search string generator from odoo/odoo#25922.

Tested on runbot: the "search more" is a bit glitchy as it closes the filter dropdown but it's something we can live with. Worth to drop a line in roadmap?

That's something that I actually like, because when hitting "apply", you don't have to apply it again. What's the problem on that? 🤔

yajo · 2018-08-13T12:09:25Z

Nice, we have now human-readable leaf strings for advanced searches.

I was expecting odoo/odoo#25922 to get merged faster and me being able to backport it to OCB, but whatever. It's here in the addon now.

If other addons require this system, it could be split in a separate addon, but I think this is a good approach to keep it simple for now, when that's not happening.

This is how it looks now:

pedrobaeza · 2018-08-14T14:34:11Z

@yajo excellent addition!

One nitpicking about the human readable format: please use → character instead of > and remove spaces for better visualization and for differentiating from the operator "greater than". Are and and or words translatable?

@simahawk can you update your review?

yajo · 2018-08-16T08:31:10Z

Are and and or words translatable?

Yes.

All done.

pedrobaeza · 2018-08-16T15:50:38Z

Merged in e764017

JBF91 · 2018-09-13T11:11:25Z

Why manifest.py became openerp.py after merging?

yajo · 2018-09-13T11:42:11Z

😕 weird...

pedrobaeza · 2018-09-13T11:58:08Z

Mea culpa, I screwed up on the squashing. Fixing directly.

yajo added the needs review label Jul 20, 2018

yajo added this to the 11.0 milestone Jul 20, 2018

yajo self-assigned this Jul 20, 2018

yajo mentioned this pull request Jul 20, 2018

[11.0][MIG] web_advanced_search_x2x #984

Closed

pedrobaeza mentioned this pull request Jul 20, 2018

Migration to version 11.0 #739

Closed

68 tasks

yajo force-pushed the 11.0-web_advanced_search_x2x-mig branch 2 times, most recently from bbf2f36 to 22b020c Compare July 20, 2018 09:50

pedrobaeza requested a review from JBF91 July 21, 2018 15:04

pedrobaeza previously requested changes Jul 22, 2018

View reviewed changes

elicoidal approved these changes Jul 22, 2018

View reviewed changes

yajo commented Jul 23, 2018

View reviewed changes

MeetKD suggested changes Jul 29, 2018

View reviewed changes

web_advanced_search/__manifest__.py Outdated

],

'installable': True,

"application": False,

}

This comment was marked as resolved.

Sign in to view

simahawk approved these changes Aug 7, 2018

View reviewed changes

pedrobaeza mentioned this pull request Aug 10, 2018

[11.0][ADD] web_advanced_search_x2x: Renamed to web_advanced_search OCA/OpenUpgrade#1481

Merged

yajo added work in progress and removed needs review labels Aug 13, 2018

yajo added needs review and removed work in progress labels Aug 13, 2018

pedrobaeza approved these changes Aug 16, 2018

View reviewed changes

pedrobaeza closed this Aug 16, 2018

pedrobaeza force-pushed the 11.0-web_advanced_search_x2x-mig branch from 76139cf to 3226b4c Compare August 16, 2018 15:50

pedrobaeza deleted the 11.0-web_advanced_search_x2x-mig branch August 16, 2018 15:50

		@@ -0,0 +1,283 @@
		/* Copyright 2015 Therp BV <http://therp.nl>


		To use this module, you need to:

		* open the advanced search options in a search view


		To search for properties of linked records (ie invoices for customers with a credit limit higher than X):

		* open the advanced search options in a search view

		@@ -0,0 +1,13 @@
		<?xml version="1.0" encoding="UTF-8"?>
		<!-- Copyright 2017 Jairo Llopis <jairo.llopis@tecnativa.com>

[MIG][REF] web_advanced_search: Rename, refactor, migrate #999

[MIG][REF] web_advanced_search: Rename, refactor, migrate #999

Conversation

yajo commented Jul 20, 2018

pedrobaeza left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elicoidal left a comment

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yajo left a comment

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

simahawk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yajo commented Aug 13, 2018

yajo commented Aug 13, 2018 • edited Loading

pedrobaeza commented Aug 14, 2018

yajo commented Aug 16, 2018

pedrobaeza commented Aug 16, 2018

JBF91 commented Sep 13, 2018

yajo commented Sep 13, 2018

pedrobaeza commented Sep 13, 2018

yajo commented Aug 13, 2018 •

edited

Loading