-
-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.0][ADD][website_snippet_mass_mailing_partner] Snippet + name #201
Conversation
crm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gurneyalex Runbot fails because it lacks this repo, could you add it please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added it.
Let you have the name field in the mass mailing subscription snippet. When somebody tells his name, a partner is linked (if a match is found) or created.
74cd693
to
2034582
Compare
Rebased to get update. |
Tested. Something is wrong. Let's explain. 1 - Go to http://3147655-201-203458.runbot1.odoo-community.org/, in home page there is a snippet for Mailing List "Imported Contacts" |
No, @rafaelbn, that task is subrogated to the module mass_mailing_partner, that filters and matches partner_id by email, and avoid these duplicates. |
("opt_out", "=", False), | ||
]) | ||
partner = Partner.search( | ||
[("email", "=ilike", email), ("name", "=ilike", name)], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only match by email. The name can be easily twisted or typoed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not done by mass_mailing_partner?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I was working around something that it should do, and now you have it in OCA/crm#96. Thanks for the point.
This module should go on OCA/social |
Why do you close this? Actually, the patch is not correct. |
You just told me to put it in OCA/social |
Sorry, I didn't remember, hehe... |
Let you have the name field in the mass mailing subscription snippet.
When somebody tells his name, a partner is linked (if a match is found) or created.
@Tecnativa.