[9.0][MIG][website_portal_purchase_product] Migration of website_product_supplier

[yajo]

Module has been renamed from website_product_supplier to website_portal_purchase_product, which follows better the guidelines.

Many code has changed to make it compatible with the backported website_portal_v10 collection.

Complete refactor of module.

• It now uses the supplier flag on user's commercial partner to grant access to features.
• No controllers use sudo(), but ACLs and record access rules.
• JavaScript and CSS are simplified or directly removed.
• Controllers now are product.template-oriented, not product.supplierinfo-oriented.
• ... although product.supplierinfo is still used for record access rules.
• Based completely on website_portal_v10.
• Views are better split in files.
• Benefit of new website_form module for Odoo v9.
• LGPL, with original author's consent.

WIP until these are merged:

• [9.0][website_portal_v10] Backport of website_portal from v10 #204
• [MIG][9.0][website_portal_purchase] Migrate #202

@Tecnativa

[pedrobaeza]

Better to make it with rules.

[yajo]

Dependencies are merged, rebased, please someone tag as ready to review.

[yajo]

@rafaelbn please comment on PR, not on commits. Your requests were already addressed.

[rafaelbn]

Rebuilding for testing, this PR is ready @yajo @sergio-teruel

[yajo]

It's waiting approvals

[rafaelbn]

Please @yajo try to test it in runbot, I get:

[yajo]

That's because no sass is available in runbot, I rebased to see if it gets fixed.

[pedrobaeza]

FYI, we fixed it some time ago. Rebasing should be enough.

[yajo]

Travis hits #296

[yajo]

Travis should go ✔️ now.

[pedrobaeza]

You can take the occasion to squash a bit the commits.

[yajo]

Seems like the tour is broken now, I'll try fix; and squash when it goes ✔️

[yajo]

Weird, if you create a demo user for the tour using the strategy outlined in odoo/odoo#13902, you cannot use it as the tour's login, because test fails with:

Traceback (most recent call last):
`   File "/home/travis/build/OCA/website/website_portal_purchase_product/tests/test_ui.py", line 35, in test_ui_website_portal_product_manager
`     login="tourman")
`   File "/home/travis/odoo-9.0/openerp/tests/common.py", line 437, in phantom_js
`     self.authenticate(login, login)
`   File "/home/travis/odoo-9.0/openerp/tests/common.py", line 295, in authenticate
`     session.context = Users.context_get(self.cr, uid) or {}
`   File "/home/travis/odoo-9.0/openerp/api.py", line 250, in wrapper
`     return old_api(self, *args, **kwargs)
`   File "<decorator-gen-21>", line 2, in context_get
`   File "/home/travis/odoo-9.0/openerp/tools/cache.py", line 85, in lookup
`     value = d[key] = self.method(*args, **kwargs)
`   File "/home/travis/odoo-9.0/openerp/addons/base/res/res_users.py", line 428, in context_get
`     res = getattr(user, k) or False
`   File "/home/travis/odoo-9.0/openerp/fields.py", line 836, in __get__
`     return record._cache[self]
`   File "/home/travis/odoo-9.0/openerp/models.py", line 6141, in __getitem__
`     return value.get() if isinstance(value, SpecialValue) else value
`   File "/home/travis/odoo-9.0/openerp/fields.py", line 39, in get
`     raise self.exception
` MissingError: ('Record does not exist or has been deleted.', None)

So I opened odoo/odoo#14777 to see if in the future we can have the portal user everywhere, and falled back to changing permisions of demo user for now. Let's see if that works.

[rafaelbn]

Please @yajo could you review travis?

[pedrobaeza]

Closing this due to no continuation in the project. If somebody has interest on it, he/she can open another PR taking this work.