[ADD][website_multi_theme] Allow different themes by website #354

yajo · 2017-06-15T12:40:59Z

This a somewhat hacky addon that adds support for setting a different theme by website.

It includes a workaround for odoo/odoo#17635 and odoo/odoo#17970.

It bundles lazy support for theme_bootswatch and a bunch of popular private themes found in the app store.

@Tecnativa

pedrobaeza

Very good module! Little things to change.

pedrobaeza · 2017-06-19T00:50:46Z

website_multi_theme/README.rst

+
+This addon includes a theme called theme_demo that will allow you to test its
+behavior and serves as a template on how to develop a multiwebsite-wise theme.
+All it does is transform the style of primary buttons to white background and


s/is transform/is to transform

pedrobaeza · 2017-06-19T00:51:22Z

website_multi_theme/README.rst

+#. In *Advanced > Multiwebsite theme*, pick one of the available themes.
+
+Once you save, any default theme you had enabled before will become the theme
+for any websites that have no *Multiwebsite theme* selected, and those that do


s/websites/website
s/have/has

pedrobaeza · 2017-06-19T00:52:49Z

website_multi_theme/README.rst

+------------
+
+* Rafael Blasco <rafael.blasco@tecnativa.com>
+* Antonio Espinosa <antonioea@antiun.com>


Change it to Tecnativa also, as it was Tecnativa's employee also.

pedrobaeza · 2017-06-19T00:53:02Z

website_multi_theme/__manifest__.py

@@ -0,0 +1,37 @@
+# -*- coding: utf-8 -*-
+# Copyright 2015 Antiun Ingenieria S.L. - Antonio Espinosa


Tecnativa did not exist in 2015...

pedrobaeza · 2017-06-19T00:53:37Z

website_multi_theme/__manifest__.py

+
+{
+    "name": "Website Multi Theme",
+    "summary": "Support theme per website",


Support different theme per website

pedrobaeza · 2017-06-19T00:55:50Z

website_multi_theme/models/website_theme.py

+                _logger.debug("Found ref %s: %r", one.assets_ref, one.view_id)
+            except ValueError:
+                one.view_id = False
+                _logger.info("Ref not found: %s", one.assets_ref)


I think you shouldn't log this, and less with info level.

yajo · 2017-06-29T11:04:30Z

This changed so much that I just squashed everything again, sorry for that.

It should be ready to review now. I removed many important points from the known issues that basically mean:

You can now support 100% of any theme features as long as they adhere to Odoo standards (including live preview and customisations, no matter how many views are involved).
When updating the addon, none of those customisations are lost.

yelizariev · 2017-07-14T08:15:52Z

website_multi_theme/README.rst

+
+Themes in the above lists will become multiwebsite when installed along this
+module. **If they get installed after ``website_multi_theme``, update this
+module manually**, or it will not be notified of such change.


What about calling _multi_theme_update from init method to avoid asking user update the module manually?

Well, you will need at least to restart Odoo service, so it's also not the best solution. The ideal will be to put a hook after installing the module, but it can be very intrusive.

As I understand init method of installed modules is called whenever any new module is installed. So, no need to restart Odoo. Did I miss something?

Uf, that's even more intrusive! I don't like too much that kind of "patches".

I don't understand what is wrong here and why do you call it "patch".
_multi_theme_update doesn't make monkey patch or something like that. It's a function that author asks user to call manually (via updating the module), while I suggest to do that automatically by moving it to init

If the problem is that the function will be called too often, we can think about optimizing it

Yeah, that's what I was thinking about, but as said, @yajo knows better the architecture, so he will answer on Monday (today he's on holidays).

If there's a standard way to trigger a function whenever an addon is installed or updated, then I'm on favor of using it and letting the module in a "just works" status, unless it means monkey patching something. @yelizariev, do you have any examples of how init works that way?

Actually, I was wrong saying that

init method of installed modules is called whenever any new module is installed.

The correct statement should be:

init method of installed modules is called whenever any new module that updates related model is installed.

So, it's not a solution.

Spitballing here, but what about an override in ir.module.module.upstream_dependencies to inject this module in the event that the category is Theme? I think injecting it into the dependencies would cause it to get updated?

Odoo already seems to use this category for other logic such as the theme installer, so I think it would be a safe target here too.

yelizariev · 2017-07-14T09:51:06Z

I got an error on runbot, probably, not related to the module

"ERROR: Cannot load compass.\A Maybe you should install the compass gem using this extra argument:\A \A $ sudo gem install compass --pre\A This error occured while compiling the bundle 'web.assets_frontend' containing:\A - /web/static/lib/bootstrap/less/variables.less\A - /web/static/lib/bootstrap/less/mixins/vendor-prefixes.less\A - /web/static/lib/bootstrap/less/mixins/buttons.less\A - /web/static/src/less/variables.less\A - /web/static/src/less/utils.less\A - /web_editor/static/src/less/web_editor.variables.less\A - /web/static/src/less/import_bootstrap.less\A - /web_editor/static/src/less/web_editor.common.less\A - /website/static/src/less/website.ui.less\A - /website/static/src/less/website.ui.components.less\A - /website/static/src/less/website.wrapwrap.less\A - /website/static/src/less/website.snippets.less\A - /website/static/src/less/website.zoomodoo.less\A - /website_portal/static/src/less/website_portal.less\A - /website_blog/static/src/less/website_blog.less\A - /website_snippet_country_dropdown/static/src/css/style.sass\A - /website_form/static/src/less/website_form.less\A - /website_portal_sale/static/src/less/website_portal_sale.less\A - /website_snippet_data_slider/static/lib/slick-1.6.0/slick.less\A - /website_snippet_data_slider/static/lib/slick-1.6.0/slick-theme.less"

yelizariev · 2017-07-14T10:00:03Z

Not able to check on runbot for the reason above.

PS. To test multi website on runbot you can use domains like below:
3298335-354-7c6341.website1.runbot2.odoo-community.org
3298335-354-7c6341.website2.runbot2.odoo-community.org

pedrobaeza · 2017-07-14T10:00:30Z

There are some dependencies to install. @yajo, not all .travis.yml is parsed on runbot. I think you need to use rvm method for installing ruby and company.

pedrobaeza · 2017-07-14T10:01:37Z

@yelizariev as the multi-domain is tricky on runbot, better to try on your own deployment.

yelizariev · 2017-07-14T10:03:32Z

I believe it should work with the trick I mentioned

yajo · 2017-07-20T09:04:44Z

Yet again OCA/maintainer-quality-tools#465, starting to get tired of it. Let's see if next build works.

yelizariev · 2017-07-20T11:07:47Z

Got an error on runbot

2017-07-20 11:05:38,438 166 INFO openerp_test werkzeug: 172.17.42.1 - - [20/Jul/2017 11:05:38] "POST /website/translations HTTP/1.0" 200 -
2017-07-20 11:05:39,187 166 WARNING openerp_test odoo.addons.website.models.ir_ui_view: Could not find view object with xml_id 'website_multi_theme.auto_assets_website_4'
2017-07-20 11:05:39,190 166 ERROR openerp_test odoo.addons.website.models.ir_http: 500 Internal Server Error:

Traceback (most recent call last):
File "/home/odoo/odoo-10.0/addons/website/models/ir_http.py", line 273, in _handle_exception
response = super(Http, cls)._handle_exception(exception)
File "/.repo_requirements/odoo/odoo/addons/base/ir/ir_http.py", line 169, in _handle_exception
return request._handle_exception(exception)
File "/.repo_requirements/odoo/odoo/http.py", line 768, in _handle_exception
return super(HttpRequest, self)._handle_exception(exception)
File "/.repo_requirements/odoo/odoo/addons/base/ir/ir_http.py", line 195, in _dispatch
result = request.dispatch()
File "/.repo_requirements/odoo/odoo/http.py", line 827, in dispatch
r = self._call_function(**self.params)
File "/.repo_requirements/odoo/odoo/http.py", line 333, in _call_function
return checked_call(self.db, *args, **kwargs)
File "/.repo_requirements/odoo/odoo/service/model.py", line 101, in wrapper
return f(dbname, *args, **kwargs)
File "/.repo_requirements/odoo/odoo/http.py", line 329, in checked_call
result.flatten()
File "/.repo_requirements/odoo/odoo/http.py", line 1259, in flatten
self.response.append(self.render())
File "/.repo_requirements/odoo/odoo/http.py", line 1252, in render
return env["ir.ui.view"].render_template(self.template, self.qcontext)
File "/.repo_requirements/odoo/odoo/addons/base/ir/ir_ui_view.py", line 1039, in render_template
return self.browse(self.get_view_id(template)).render(values, engine)
File "/home/odoo/odoo-10.0/addons/website/models/ir_ui_view.py", line 110, in render
return super(View, self).render(values, engine=engine)
File "/home/odoo/odoo-10.0/addons/web_editor/models/ir_ui_view.py", line 26, in render
return super(IrUiView, self).render(values=values, engine=engine)
File "/.repo_requirements/odoo/odoo/addons/base/ir/ir_ui_view.py", line 1059, in render
return self.env[engine].render(self.id, qcontext)
File "/.repo_requirements/odoo/odoo/addons/base/ir/ir_qweb/ir_qweb.py", line 53, in render
return super(IrQWeb, self).render(id_or_xml_id, values=values, **context)
File "/.repo_requirements/odoo/odoo/addons/base/ir/ir_qweb/qweb.py", line 248, in render
self.compile(template, options)(self, body.append, values or {})
File "/.repo_requirements/odoo/odoo/addons/base/ir/ir_qweb/qweb.py", line 317, in _compiled_fn
raise e
QWebException: None
Traceback (most recent call last):
File "/.repo_requirements/odoo/odoo/addons/base/ir/ir_qweb/qweb.py", line 341, in get_template
document = options.get('load', self.load)(template, options)
File "/.repo_requirements/odoo/odoo/addons/base/ir/ir_qweb/ir_qweb.py", line 81, in load
template = env['ir.ui.view'].read_template(name)
File "/.repo_requirements/odoo/odoo/addons/base/ir/ir_ui_view.py", line 934, in read_template
return self._read_template(self.get_view_id(xml_id))
File "<decorator-gen-37>", line 2, in get_view_id
File "/.repo_requirements/odoo/odoo/tools/cache.py", line 87, in lookup
value = d[key] = self.method(*args, **kwargs)
File "/home/odoo/odoo-10.0/addons/website/models/ir_ui_view.py", line 80, in get_view_id
raise ValueError('View %r in website %r not found' % (xml_id, self._context['website_id']))
ValueError: View 'website_multi_theme.auto_assets_website_4' in website 1 not found

load could not load template
Template: website_multi_theme.auto_assets_website_4

2017-07-20 11:05:39,448 166 INFO openerp_test werkzeug: 172.17.42.1 - - [20/Jul/2017 11:05:39] "GET / HTTP/1.0" 500 -

yelizariev · 2017-07-20T11:19:10Z

error is disappeared after reloading the page.

But there is another issue.

I set Multiwebsite Bootswatch Theme for website1 and Multiwebsite Demo Theme for website2. But both websites looks the same. I am sure that I open correct websites, because ones have different menus and footers

yelizariev · 2017-07-20T11:21:15Z

~~Another issue.~~

~~The same web url shows different style for admin and public user~~

yelizariev · 2017-07-20T11:25:13Z

Seems that last issue was just a cache problem

yelizariev · 2017-07-20T11:35:09Z

As for different websites I need to clarify that I used Customize theme option. And then theme is applied for all websites. Is it expected behaviour?

yelizariev · 2017-07-20T11:43:32Z

One can try himself while build exist

Click Customize theme here:
http://3298774-354-331dc5.runbot1.odoo-community.org/page/website_multi_theme.demo_page

Check what happens here:
http://3298774-354-331dc5.website1.runbot1.odoo-community.org/page/website_multi_theme.demo_page
http://3298774-354-331dc5.website2.runbot1.odoo-community.org/page/website_multi_theme.demo_page

yelizariev · 2017-08-28T07:01:49Z

Shall we report to odoo about this problem? There already was something similar, for example:
odoo/odoo@fa9782d

yajo · 2017-08-28T10:27:08Z

😍 I think you hit the point @yelizariev! Thanks, I'll dig from there.

BTW, as you said in #354 (comment), this is not this PR's problem, so not sure if should it be blocked...

…instead of a 500 if a view is not found Fix tests that were getting warnings logged and random timeouts.

yajo · 2017-08-28T11:22:00Z

OK, it should be fixed now. It was a timeout after all. Can't believe I lost so many hours finding that line... 😢

MiquelRForgeFlow · 2017-08-28T12:47:26Z

Now it's 🍏

pedrobaeza · 2017-08-28T13:59:25Z

@lasley please remove your "Requested changes" if you think everything is OK.

* [ADD][website_multi_theme] Allow different themes by website This a somewhat hacky addon that adds support for setting a different theme by website. Always updates views arch in development and demo instances. This allows faster development, while keeping stability and no surprises in production. * fixup! [ADD][website_multi_theme] Allow different themes by website * fixup! fixup! [ADD][website_multi_theme] Allow different themes by website * fixup! fixup! fixup! [ADD][website_multi_theme] Allow different themes by website * fixup! fixup! fixup! fixup! [ADD][website_multi_theme] Allow different themes by website * fixup! fixup! fixup! fixup! fixup! [ADD][website_multi_theme] Allow different themes by website * fixup! fixup! fixup! fixup! fixup! fixup! [ADD][website_multi_theme] Allow different themes by website * fixup! fixup! fixup! fixup! fixup! fixup! fixup! [ADD][website_multi_theme] Allow different themes by website * [FIX][website_legal_page] Correctly raise a 404 error instead of a 500 if a view is not found * fixup! fixup! fixup! fixup! fixup! fixup! fixup! [ADD][website_multi_theme] Allow different themes by website * fixup! [FIX][website_legal_page] Correctly raise a 404 error instead of a 500 if a view is not found * squash! fixup! [FIX][website_legal_page] Correctly raise a 404 error instead of a 500 if a view is not found Fix tests that were getting warnings logged and random timeouts.

yajo added the needs review label Jun 15, 2017

yajo added this to the 10.0 milestone Jun 15, 2017

yajo self-assigned this Jun 15, 2017

This was referenced Jun 15, 2017

[FIX][website] Skip other website's views odoo/odoo#17635

Closed

Odoo multi-website improvements debate odoo/odoo#9745

Closed

yajo force-pushed the 10.0-website_multi_theme branch from ea9219e to fbdc57d Compare June 15, 2017 15:15

pedrobaeza requested changes Jun 19, 2017

View reviewed changes

yajo added work in progress and removed needs review labels Jun 26, 2017

yajo force-pushed the 10.0-website_multi_theme branch from efc66c0 to de579e2 Compare June 29, 2017 11:02

yajo added needs review and removed work in progress labels Jun 29, 2017

pedrobaeza approved these changes Jul 3, 2017

View reviewed changes

yelizariev reviewed Jul 14, 2017

View reviewed changes

yajo added needs fixing work in progress and removed needs review labels Jul 21, 2017

squash! fixup! [FIX][website_legal_page] Correctly raise a 404 error …

860fa9b

…instead of a 500 if a view is not found Fix tests that were getting warnings logged and random timeouts.

lasley approved these changes Aug 28, 2017

View reviewed changes

lasley merged commit c66aaaf into OCA:10.0 Aug 28, 2017

pedrobaeza deleted the 10.0-website_multi_theme branch August 28, 2017 16:40

yajo mentioned this pull request Jan 31, 2018

[FIX] skip handling non-theme or non extenstion templates #410

Closed

		@@ -0,0 +1,37 @@
		# -- coding: utf-8 --
		# Copyright 2015 Antiun Ingenieria S.L. - Antonio Espinosa

[ADD][website_multi_theme] Allow different themes by website #354

[ADD][website_multi_theme] Allow different themes by website #354

Conversation

yajo commented Jun 15, 2017 • edited Loading

pedrobaeza left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yajo commented Jun 29, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yelizariev Jul 14, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yelizariev Jul 14, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lasley Aug 14, 2017 • edited Loading

Choose a reason for hiding this comment

yelizariev commented Jul 14, 2017

yelizariev commented Jul 14, 2017

pedrobaeza commented Jul 14, 2017

pedrobaeza commented Jul 14, 2017

yelizariev commented Jul 14, 2017

yajo commented Jul 20, 2017

yelizariev commented Jul 20, 2017

yelizariev commented Jul 20, 2017

yelizariev commented Jul 20, 2017 • edited Loading

yelizariev commented Jul 20, 2017

yelizariev commented Jul 20, 2017 • edited Loading

yelizariev commented Jul 20, 2017

yelizariev commented Aug 28, 2017

yajo commented Aug 28, 2017

yajo commented Aug 28, 2017

MiquelRForgeFlow commented Aug 28, 2017

pedrobaeza commented Aug 28, 2017

yajo commented Jun 15, 2017 •

edited

Loading

yelizariev Jul 14, 2017 •

edited

Loading

yelizariev Jul 14, 2017 •

edited

Loading

lasley Aug 14, 2017 •

edited

Loading

yelizariev commented Jul 20, 2017 •

edited

Loading

yelizariev commented Jul 20, 2017 •

edited

Loading