[13.0][MIG] website_form_recaptcha: Migration to 13.0 #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: README.md
* Update website_form_recaptcha to v10
[FIX] remove en.po that was erroneously created by transbot
- Remove groups on ir_config_paramater records (gone in 11.0) - Move error mapping to private function to allow translation
The test was passing a list while the method is expecting a string Files don't need to have the execute flag on flake8 was complaining about E501 line too long
Currently translated at 100,0% (12 of 12 strings) Translation: website-11.0/website-11.0-website_form_recaptcha Translate-URL: https://translation.odoo-community.org/projects/website-11-0/website-11-0-website_form_recaptcha/pt_BR/
Currently translated at 100,0% (12 of 12 strings) Translation: website-11.0/website-11.0-website_form_recaptcha Translate-URL: https://translation.odoo-community.org/projects/website-11-0/website-11-0-website_form_recaptcha/de/
Currently translated at 100.0% (12 of 12 strings) Translation: website-11.0/website-11.0-website_form_recaptcha Translate-URL: https://translation.odoo-community.org/projects/website-11-0/website-11-0-website_form_recaptcha/de/
Currently translated at 100,0% (12 of 12 strings) Translation: website-11.0/website-11.0-website_form_recaptcha Translate-URL: https://translation.odoo-community.org/projects/website-11-0/website-11-0-website_form_recaptcha/es/
- When website_crm_phone_validation is installed, the captcha validation is called twice so the form allways fail as with a 'timeout-or-duplicate' error.
* API keys can now be configured via website settings which in turn allow to customize the values per website in a multi-website instance; * move all internal APIs to the model `website.form.recaptcha` so that we do not depend anymore on the controller if we need to integrate it into other pieces of code.
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
- Fix tests. - Remove outdated tests. - Remove unneeded data file. - Add migration script.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: website-12.0/website-12.0-website_form_recaptcha Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_form_recaptcha/
Added a dependency. Without it, you get:
form_builder_send is undefined
Currently translated at 100.0% (23 of 23 strings) Translation: website-12.0/website-12.0-website_form_recaptcha Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_form_recaptcha/pt_BR/
Tardo
force-pushed
the
13.0-mig-website_form_recaptcha
branch
from
06fe1d2
to
225d366
Compare
chienandalu
reviewed
Mar 31, 2020
|
@chienandalu if prefer i can revert the changes and use the original commit history: |
|
I think you have to redo commit history, pass "black, isort and prettier", and then copy what was in the other PR, committing with that author, and then add your changes to complete the migration. |
Tardo
force-pushed
the
13.0-mig-website_form_recaptcha
branch
from
225d366
to
ac7cfea
Compare
Tardo
force-pushed
the
13.0-mig-website_form_recaptcha
branch
from
ac7cfea
to
28fac13
Compare
|
Changes done! |
pedrobaeza
approved these changes
Apr 1, 2020
|
/ocabot merge |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 01e851f. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseded #684
cc @Tecnativa TT21698