[13.0][MIG] website_form_recaptcha #684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 15, 2020
bjornbillen
force-pushed
the
13.0-mig-website_form_recaptcha
branch
from
ea7bb06
to
465f1f5
Compare
tarteo
requested changes
Jan 31, 2020
|
|
||
| def _get_api_credentials(self, website=None): | ||
| # website override | ||
| website = website or http.request.website |
There was a problem hiding this comment.
System parameter recaptcha.key.site and recaptcha.key.secret do nothing.
There was a problem hiding this comment.
@tarteo : Can you elaborate a little more on this? I can't see any config parameters being created by the module? There's something written in the module description that refers to the system parameters, which should probably be removed...
bjornbillen
force-pushed
the
13.0-mig-website_form_recaptcha
branch
from
465f1f5
to
0bf75bb
Compare
bizzappdev
suggested changes
Feb 7, 2020
Conflicts: README.md
* Update website_form_recaptcha to v10
[FIX] remove en.po that was erroneously created by transbot
- Remove groups on ir_config_paramater records (gone in 11.0) - Move error mapping to private function to allow translation
The test was passing a list while the method is expecting a string Files don't need to have the execute flag on flake8 was complaining about E501 line too long
Currently translated at 100,0% (12 of 12 strings) Translation: website-11.0/website-11.0-website_form_recaptcha Translate-URL: https://translation.odoo-community.org/projects/website-11-0/website-11-0-website_form_recaptcha/pt_BR/
Currently translated at 100,0% (12 of 12 strings) Translation: website-11.0/website-11.0-website_form_recaptcha Translate-URL: https://translation.odoo-community.org/projects/website-11-0/website-11-0-website_form_recaptcha/de/
Currently translated at 100.0% (12 of 12 strings) Translation: website-11.0/website-11.0-website_form_recaptcha Translate-URL: https://translation.odoo-community.org/projects/website-11-0/website-11-0-website_form_recaptcha/de/
Currently translated at 100,0% (12 of 12 strings) Translation: website-11.0/website-11.0-website_form_recaptcha Translate-URL: https://translation.odoo-community.org/projects/website-11-0/website-11-0-website_form_recaptcha/es/
- When website_crm_phone_validation is installed, the captcha validation is called twice so the form allways fail as with a 'timeout-or-duplicate' error.
* API keys can now be configured via website settings which in turn allow to customize the values per website in a multi-website instance; * move all internal APIs to the model `website.form.recaptcha` so that we do not depend anymore on the controller if we need to integrate it into other pieces of code.
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
- Fix tests. - Remove outdated tests. - Remove unneeded data file. - Add migration script.
This was rendering the config dialog useless.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: website-12.0/website-12.0-website_form_recaptcha Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_form_recaptcha/
Added a dependency. Without it, you get:
form_builder_send is undefined
Currently translated at 100.0% (23 of 23 strings) Translation: website-12.0/website-12.0-website_form_recaptcha Translate-URL: https://translation.odoo-community.org/projects/website-12-0/website-12-0-website_form_recaptcha/pt_BR/
bjornbillen
force-pushed
the
13.0-mig-website_form_recaptcha
branch
from
efd146f
to
cb64581
Compare
|
ping @bjornbillen please resolve conflicts |
|
Well, i saw that @bjornbillen is no longer active on github... so i will supersede this pr. |
|
@Tardo Go ahead mate. IMO, it takes way too long to get changes done over here. Currently can't affort to waste such time anymore. |
|
Oh! @bjornbillen sorry xD i have not seen any activity on your feed :P |
|
Superseded by #709 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.