[12.0][FIX] website_sale_checkout_country_vat: inherit the correct view #351
Conversation
|
This PR has the |
|
@yajo can we merge this? |
|
We could, but this fix is incomplete. 🤷♂️ |
|
OK, then please finish it |
This module happened to be working accidentally because [it was inheriting from a view that had another inheriting view which defined the necessary elements][1]; but that view can be disabled and then this module breaks. Fixed by inheriting from the correct view. Also benefits from OCA/website#720 by using readonly mode if that module is updated. @Tecnativa TT17694 [1]: https://github.com/odoo/odoo/blob/6e99a89574d11811c03fe3cdc61922352a9610ea/addons/website_sale/views/templates.xml#L1296
yajo
force-pushed
the
12.0-website_sale_checkout_country_vat-fix_template_parent
branch
from
030986e
to
f44cd5e
Compare
|
Finished. |
pedrobaeza
changed the title
|
/ocabot merge minor |
|
@pedrobaeza The merge process could not start, because of exception <class 'requests.exceptions.ReadTimeout'>: A connection-level exception occurred: HTTPSConnectionPool(host='api.github.com', port=443): Read timed out. (read timeout=10). |
|
/ocabot merge minor |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-351-by-pedrobaeza-bump-minor. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot merge minor |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-351-by-pedrobaeza-bump-minor. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-351-by-pedrobaeza-bump-minor. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at d31f8f8. Thanks a lot for contributing to OCA. ❤️ |
yajo
deleted the
12.0-website_sale_checkout_country_vat-fix_template_parent
branch
|
We need OCA/website#720 to fully benefit from this patch. |
This module happened to be working accidentally because it was inheriting from a view that had another inheriting view which defined the necessary elements; but that view can be disabled and then this module breaks.
Fixed by inheriting from the correct view.
Also benefits from OCA/website#720 by using readonly mode if that module is updated.
@Tecnativa TT17694