Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0] Add plantuml diagram for single pack transfer #131

Merged
merged 2 commits into from
Jan 25, 2021
Merged

[13.0] Add plantuml diagram for single pack transfer #131

merged 2 commits into from
Jan 25, 2021

Conversation

guewen
Copy link
Member

@guewen guewen commented Jan 18, 2021

No description provided.

@guewen guewen requested a review from sebalix January 18, 2021 09:05
@guewen
Copy link
Member Author

guewen commented Jan 18, 2021

@sebalix Do I do it correctly?

simahawk
simahawk approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

sebalix
sebalix reviewed Jan 18, 2021
View reviewed changes
Copy link
Contributor

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool :) One small glitch!

shopfloor/docs/single_pack_transfer_diag_seq.txt Outdated Show resolved Hide resolved
@guewen guewen force-pushed the 13.0-shopfloor-diagrams branch 2 times, most recently from 5fc67b6 to 2aa6aaa Compare January 18, 2021 09:33
@rousseldenis
Copy link
Sponsor Contributor

@guewen I think there is a .plantuml file extension for those kind of files. LGTM, should be an OCA requirement 😃

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@guewen
Copy link
Member Author

guewen commented Jan 25, 2021

I think there is a .plantuml file extension for those kind of files.

Apparently several :D qjebbs/vscode-plantuml#138 (comment)
I'll change the files to .plantuml which is the most indicative.

@guewen
Copy link
Member Author

guewen commented Jan 25, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-131-by-guewen-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6f5ee6e into OCA:13.0 Jan 25, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6f5ee6e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

@sebalix sebalix sebalix approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@guewen @rousseldenis @OCA-git-bot @simahawk @sebalix