Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] shopfloor_checkout_sync #294

Merged
merged 3 commits into from
Sep 24, 2021
Merged

[14.0][MIG] shopfloor_checkout_sync #294

merged 3 commits into from
Sep 24, 2021

Conversation

hailangvn
Copy link
Contributor

@hailangvn hailangvn mentioned this pull request Sep 22, 2021
Closed
14 tasks
sebalix
sebalix reviewed Sep 23, 2021
View reviewed changes
Copy link
Contributor

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change on the test is provided in 13.0 by this commit e4c6495 (from the PR #117), you should cherry pick it before applying your migration commit.

@hailangvn hailangvn force-pushed the 14.0-mig-shopfloor_checkout_sync branch from 5551405 to c5663b0 Compare September 23, 2021 09:41
@hailangvn
Copy link
Contributor Author

Thanks @sebalix for your advice. This PR has been updated.

simahawk
simahawk requested changes Sep 24, 2021
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
test-requirements.txt Outdated Show resolved Hide resolved
@hailangvn hailangvn force-pushed the 14.0-mig-shopfloor_checkout_sync branch from c5663b0 to 25b3e6f Compare September 24, 2021 07:26
@hailangvn hailangvn force-pushed the 14.0-mig-shopfloor_checkout_sync branch from 25b3e6f to c97d2e6 Compare September 24, 2021 08:08
@hailangvn
Copy link
Contributor Author

Thanks @simahawk for your comments. This PR has been updated.

@simahawk
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-294-by-simahawk-bump-nobump, awaiting test results.

@sebalix sebalix added this to the 14.0 milestone Sep 24, 2021
@OCA-git-bot OCA-git-bot merged commit f3a827c into OCA:14.0 Sep 24, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b493584. Thanks a lot for contributing to OCA. ❤️

@hailangvn hailangvn deleted the 14.0-mig-shopfloor_checkout_sync branch September 24, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebalix sebalix sebalix left review comments

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
merged 🎉 migration
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hailangvn @simahawk @OCA-git-bot @sebalix