Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture for missing versions #79

Merged
merged 1 commit into from
Apr 25, 2021

Conversation

pwinckles
Copy link
Contributor

Fixture for missing version directories

@zimeon
Copy link
Collaborator

zimeon commented Apr 20, 2021

(py38) simeon@RottenApple fixtures> ../ocfl-validate.py 1.0/bad-objects/E010_missing_versions/
[E046] OCFL Object root inventory describes versions v3 but no corresponding version directory is present (see https://ocfl.io/1.0/spec/#E046)
[W010] OCFL Object v3 SHOULD have an inventory file but does not (see https://ocfl.io/1.0/spec/#W010)
INFO:ocfl.object:OCFL object at 1.0/bad-objects/E010_missing_versions/ is INVALID

@zimeon
Copy link
Collaborator

zimeon commented Apr 20, 2021

I think the fixture is good -- missing v3 directory in a version sequence v1...v4 but I'm not sure about E010. I think it all depends on where one considers the version sequence to be defined... I tend to think of the root manifest as key, in which case the sequence is fine. But then there is no v3 directory even though one isn't really necessary. I propose that we accept this fixture and debate what it should mean in an issue... OCFL/spec#540

@zimeon zimeon requested a review from awoods April 20, 2021 13:57
@awoods
Copy link
Member

awoods commented Apr 25, 2021

The E010 validation error seems intuitive to me... conversation continues in OCFL/spec#540 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants