Fixed: Clarify inventory.json must be present #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahankinson
requested review from
rosy1280,
awoods,
zimeon,
julianmorley and
neilsjefferies
awoods
requested changes
Jan 2, 2019
draft/spec/index.html
Outdated
| Every version directory SHOULD include an inventory file that is an <a href="#inventory">Inventory</a> | ||
| of all content for versions up to and including that particular version. Every inventory file MUST have | ||
| a corresponding <a href="#inventory-digest">Inventory Digest</a>. | ||
| Every OCFL Object MUST have an inventory file within the OCFL Object Root, |
There was a problem hiding this comment.
Minor: extraneous space in have an inventory file.
Otherwise: 👍
zimeon
requested changes
Jan 7, 2019
draft/spec/index.html
Outdated
| Every version directory SHOULD include an inventory file that is an <a href="#inventory">Inventory</a> | ||
| of all content for versions up to and including that particular version. Every inventory file MUST have | ||
| a corresponding <a href="#inventory-digest">Inventory Digest</a>. | ||
| Every OCFL Object MUST have an inventory file within the OCFL Object Root, |
|
Fixéd. |
zimeon
approved these changes
Jan 7, 2019
awoods
approved these changes
Jan 15, 2019
rosy1280
approved these changes
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #293