Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formerEditor: Andrew Hankinson #590

Closed
wants to merge 1 commit into from
Closed

Add formerEditor: Andrew Hankinson #590

wants to merge 1 commit into from

Conversation

awoods
Copy link
Member

@awoods awoods commented May 5, 2022

This PR needs additional modification to render. According to the documentation, it should work.

The non-rendering issue appears to be related to our modified respec-w3c-common.js. The formerEditors block correctly renders when replacing the script with:

    <script src="https://www.w3.org/Tools/respec/respec-w3c"

@rosy1280
Copy link
Contributor

rosy1280 commented May 5, 2022

@awoods i'm confused by your comment. is this a complete PR or are you still working on it.

@awoods awoods requested a review from zimeon May 5, 2022 15:52
@awoods awoods marked this pull request as draft May 5, 2022 15:52
@rosy1280
Copy link
Contributor

rosy1280 commented May 5, 2022

@zimeon we would need you to look into how we can update respec-w3c-common.js to make this work. can you review and figure that out for us?

@zimeon
Copy link
Contributor

zimeon commented Jun 2, 2022

Have created issue to do this after move to markdown, #599. Closing

@zimeon zimeon closed this Jun 2, 2022
@rosy1280 rosy1280 deleted the ahank-former branch July 20, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants