Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDX-9928 - fix based on ruff check #6370

Closed
wants to merge 1 commit into from
Closed

HDX-9928 - fix based on ruff check #6370

wants to merge 1 commit into from

Conversation

danmihaila
Copy link
Contributor

not sure if it is ok or enough. these changes are recommended by ruff check (default setup)

@coveralls
Copy link

coveralls commented Jun 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build #5446

Details

  • 6 of 9 (66.67%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 71.687%
Changes Missing Coverage Covered Lines Changed/Added Lines %
ckanext-hdx_pages/ckanext/hdx_pages/actions/create.py 1 2 50.0%
ckanext-hdx_pages/ckanext/hdx_pages/model.py 2 3 66.67%
ckanext-hdx_pages/ckanext/hdx_pages/views/light_page.py 1 2 50.0%
Totals Coverage Status
Change from base Build #5444: -0.007%
Covered Lines: 11776
Relevant Lines: 16427
💛 - Coveralls

@alexandru-m-g alexandru-m-g marked this pull request as draft July 10, 2024 21:07
@danmihaila danmihaila closed this Jul 23, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandru-m-g alexandru-m-g Awaiting requested review from alexandru-m-g

@ccataalin ccataalin Awaiting requested review from ccataalin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danmihaila @coveralls