Migrating lablgtk3 #513
Merged
Migrating lablgtk3 #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stevendeo
reviewed
Jul 7, 2022
| "lablgtk" | ||
| "conf-gtksourceview" | ||
| "lablgtk3" | ||
| "conf-gtksourceview3" |
There was a problem hiding this comment.
Build failed on my side without lablgtk3-sourceview3, should it be an additional dependency?
Halbaroth
force-pushed
the
migrating-lablgtk3
branch
from
1387a7e
to
4e6b134
Compare
After this commit, the AltGr-Ergo package depends on lablgtk3 and lablgtk3-sourcview3 packages. Since GtkFontChooserDialog is not supported in lalbgtk3, changing font in the editor is temporarily disabled.
Halbaroth
force-pushed
the
migrating-lablgtk3
branch
from
4e6b134
to
42a0c26
Compare
…m files are generated by Dune.
…to migrating-lablgtk3
Stevendeo
approved these changes
Jul 8, 2022
Stevendeo
reviewed
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates AltGr-Ergo from lablgtk2 to lablgtk3 and lablgtk2-sourceview2 to lablgtk3-sourceview3. In particular, the new code should fix the issue #508.