Fixed dune lang handling #214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix must be made in a "backward-compatibility" way, i.e. keep the buggy behavior for projects that have a For example, there are already lines like: |
|
Merged as part of #223 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dune-langspecification was not handled correctly. The legacy key was not handled properly and the generated dune langversion didn't use the semver minor number which is meaningful for dune. This PR fixes this and I recall the whole dune lang handling here : dune lang can either be specified in :
[fields]withdune-langkey[tools]withdunekeyIn both case, it will generate a
(lang dune major.minor)corresponding to the version specified or to the minimal version compatible if both specifications are given.