Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port to dune, upgrade opam metadata and remove unused code #14

Closed
wants to merge 5 commits into from
Closed

port to dune, upgrade opam metadata and remove unused code #14

wants to merge 5 commits into from

Conversation

avsm
Copy link
Contributor

@avsm avsm commented Feb 2, 2019 •
edited

  • removed vestigial ocamlbuild files (_tags)
  • port to dune (as dune 1.7 will issue jbuild deprecation warnings)
  • upgrade opam metadata to the 2.0 format
  • remove ocaml <4.01 support, as minimum version is now ocaml 4.02+
  • restore -inline 1000 to build rules (dropped with jbuilder port)
  • update travis to test with 4.07->4.02 inclusive

This was referenced Feb 2, 2019
Closed
Closed
Open
Open
@avsm
port to dune, upgrade opam metadata and remove unused code
c8e5193 
- removed vestigial ocamlbuild files (_tags)
- port to dune (as dune 1.7 will issue jbuild deprecation warnings)
- upgrade opam metadata to the 2.0 format
- remove ocaml <4.01 support, as minimum version is now ocaml 4.02+
- restore -inline 1000 to build rules (dropped with jbuilder port)
@avsm avsm changed the title [wip] port to dune, upgrade opam metadata and remove unused code port to dune, upgrade opam metadata and remove unused code Feb 2, 2019
@avsm
Copy link
Contributor Author

avsm commented Feb 2, 2019

And thanks to @rgrinberg, the mystery of the failing tests is resolved -- it needs to be built in release mode as dev mode includes -opaque. This PR should be ready for review now, @chambart

@chambart chambart self-assigned this Feb 2, 2019
This was referenced Feb 11, 2019
Closed
Closed
@XVilka
Copy link

XVilka commented Jun 6, 2019 

Unknown OCAML_VERSION=latest OPAM_VERSION=2.0.3
+echo (An unset OCAML_VERSION used to default to "latest", but you must now specify it.
(An unset OCAML_VERSION used to default to "latest", but you must now specify it.
+echo Try something like "OCAML_VERSION=3.12", "OCAML_VERSION=4.07", or see README-travis.md at https://github.com/ocaml/ocaml-ci-scripts )
Try something like "OCAML_VERSION=3.12", "OCAML_VERSION=4.07", or see README-travis.md at https://github.com/ocaml/ocaml-ci-scripts )

@XVilka XVilka mentioned this pull request Jun 6, 2019
Closed
XVilka
XVilka reviewed Jun 6, 2019
View reviewed changes
.travis.yml Outdated
@@ -4,12 +4,12 @@ install: wget https://raw.githubusercontent.com/ocaml/ocaml-ci-scripts/master/.t
script: bash -ex .travis-opam.sh
env:
- OCAML_VERSION=latest TESTS=true PACKAGE=ocplib-endian
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be removed since ocaml-ci-scripts removed the support for "latest" version.

@glondu
Copy link

glondu commented Sep 11, 2019

Can this be merged and released, please? (especially the jbuilder -> dune migration part)

@avsm avsm mentioned this pull request Sep 27, 2019
Closed
@chambart
Copy link
Member

I hand merged it. I didn't take the bigarray-compat part to avoid increasing the minimal ocaml version for lwt to 4.03. I will wait for #20 to be resolved to release.

I'm curious @glondu why do you care about this ? Can't debian stick to the currently released version ? There is no difference between this one and the tarball except the build system.

@chambart chambart closed this Nov 14, 2019
@glondu
Copy link

glondu commented Nov 15, 2019

I'm curious @glondu why do you care about this ? Can't debian stick to the currently released version ? There is no difference between this one and the tarball except the build system.

Yes, Debian can stick to the currently released version (1.0). When I wrote my comment, I thought that version was using jbuilder (which is not the case), and I want to get rid of jbuilder in Debian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka left review comments

Assignees

@chambart chambart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@avsm @XVilka @glondu @chambart @TheLortex