Failure running tests on s390x (a big endian architecture)

[TC01]

I've just packaged ocplib-endian 1.0 for Fedora, as it's a dependency of lwt.

It looks like there are test failures on the s390x architecture.

Fatal error: exception File "tests/test_bigstring.cppo.ml", line 133, characters 4-10: Assertion failed
W: Test 'test' fails: Command '/builddir/build/BUILD/ocplib-endian-1.0/_build/tests/test.native' terminated with error code 2
E: Failure("Tests had a 100.00% failure rate")

Looking at that file, the asserts in question are only running on big endian architectures.

I'm not sure if there is a problem with the tests or with the code, so I thought I'd file an issue. The tests seem to run properly on other architectures, but I think s390x is the only big endian architecture currently supported by Fedora.

[olafhering]

Can confirm: devel:languages:ocaml/ocaml-ocplib-endian, dune runtest fails on s390x and ppc64, happens to work on other archs.
While everything looks 'green', it is just because a dune runtest failure is marked as non-fatal.

[chambart]

Sorry for the long delay.
I could not reproduce it on a power9 (ppc64le). Which commit did you use ?

[olafhering]

ppc64le is little endian. This is the duniverse-1.0 branch.
Today I tested ppc, which fails as well.

[chambart]

Of course ppc64le is little endian... stupid me. I'm going to try to get my hand on some big endian stuff.

[chambart]

I reproduced, then looked at it for real. I should have noticed earlier, but the test is stupid. This didn't trigger because I don't often test on big endian.
I think this is fixed (I tested on ppc64). Could you confirm ?

Anyway thanks for your time and the report !

[olafhering]

Thanks, commit 4c7ce54 works for me.