Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure running tests on s390x (a big endian architecture) #20

Closed
TC01 opened this issue Oct 14, 2019 · 6 comments
Closed

Failure running tests on s390x (a big endian architecture) #20

TC01 opened this issue Oct 14, 2019 · 6 comments
Assignees
Labels

Comments

@TC01
Copy link

TC01 commented Oct 14, 2019

I've just packaged ocplib-endian 1.0 for Fedora, as it's a dependency of lwt.

It looks like there are test failures on the s390x architecture.

Fatal error: exception File "tests/test_bigstring.cppo.ml", line 133, characters 4-10: Assertion failed
W: Test 'test' fails: Command '/builddir/build/BUILD/ocplib-endian-1.0/_build/tests/test.native' terminated with error code 2
E: Failure("Tests had a 100.00% failure rate")

Looking at that file, the asserts in question are only running on big endian architectures.

I'm not sure if there is a problem with the tests or with the code, so I thought I'd file an issue. The tests seem to run properly on other architectures, but I think s390x is the only big endian architecture currently supported by Fedora.

@olafhering
Copy link

Can confirm: devel:languages:ocaml/ocaml-ocplib-endian, dune runtest fails on s390x and ppc64, happens to work on other archs.
While everything looks 'green', it is just because a dune runtest failure is marked as non-fatal.

@chambart chambart self-assigned this Nov 12, 2019
@chambart chambart added the bug label Nov 12, 2019
@chambart
Copy link
Member

Sorry for the long delay.
I could not reproduce it on a power9 (ppc64le). Which commit did you use ?

@olafhering
Copy link

ppc64le is little endian. This is the duniverse-1.0 branch.
Today I tested ppc, which fails as well.

@chambart
Copy link
Member

Of course ppc64le is little endian... stupid me. I'm going to try to get my hand on some big endian stuff.

@chambart
Copy link
Member

I reproduced, then looked at it for real. I should have noticed earlier, but the test is stupid. This didn't trigger because I don't often test on big endian.
I think this is fixed (I tested on ppc64). Could you confirm ?

Anyway thanks for your time and the report !

@olafhering
Copy link

Thanks, commit 4c7ce54 works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants