-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate unit-type and unit into two dropdowns #191
Comments
Let's think about how to best do this. Sometimes the term for the relevant Unit type is a bit obscure, and in my recent work with @roelofversteeg, I have found that first sorting my unit type is actually quite hard to do, even for me with all my previous work on Units. I found that it is much easier to search by unit name, especially if there is free-text filtering in the dropdown. |
@jcaraballo17 and @Maurier, we probably should have discussed this today, for the reasons I discussed above. Ideally we would have free-text filtering of all the fields associated with a unit, similar to what is implemented on the front-end for sensors, variables, sites, etc. Also, because UnitTypes are often obscure, I do not believe that it is a good idea to require that a user first select a UnitType before selecting a Unit. This would make things very hard and frustrating for the end user. Please discuss your ideas with the group before going very far down into delivering a solution on this one. |
@aufdenkampe - @jcaraballo17 and @Maurier need some clarity. @SRGDamia1 suggests that the unit should only be selectable by unit type, but Anthony, your last comment suggests that we don't want to do this. It would be great if you and Sara can get together and decide what you want here. Juan and Mauriel can do whatever, but we need to tell them how this should work. |
When I'd created this issue, I was only thinking of having this apply on the admin panel when adding an instrument output variable. |
If it's just in the Admin panel, it should be pretty straightforward. |
…ree-text searching and better usability of the admin.
Adding a new dropdown that is not directly a field of the model and then filtering through it is a little bit complicated. |
The search seems to be working on staging. I'd still prefer the split, but I guess that problem is an ODM2 structural one. |
The unit should only be select-able based on the unit type.
The text was updated successfully, but these errors were encountered: