-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom method can now have nullable parameters and nullable arguments #1090
base: release-8.x
Are you sure you want to change the base?
Conversation
@@ -761,7 +761,7 @@ protected virtual Expression BindCustomMethodExpressionOrNull(SingleValueFunctio | |||
MethodInfo methodInfo; | |||
if (UriFunctionsBinder.TryGetMethodInfo(node.Name, methodArgumentsType, out methodInfo)) | |||
{ | |||
return ExpressionBinderHelper.MakeFunctionCall(methodInfo, context.QuerySettings, arguments); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have trouble seeing why HandleNullPropagation check is needed in custom functions. Do you know of a use case where this could be used for custom functions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xuzhg Any comment to my question
…nctionCall in wrong method
Please add a description to what the pr does. |
Please add some test to this Pr |
Fixes #1084