Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DependsOn Ids for Multipart/Mixed Batch #1020

Merged
merged 5 commits into from
Jan 12, 2018
Merged

DependsOn Ids for Multipart/Mixed Batch #1020

merged 5 commits into from
Jan 12, 2018

Commits on Dec 20, 2017

  1. dependsOn Ids for Multipart/Mixed Batch 

    - Reader extracts contentId header value for both changeset and top-level requests;
- Uses DependsOnIdsTracker to track request ids in Multipart/Mixed batch;
- DependsOnIds validation is performed only for JsonBatch since it is client provided; not for Multipart/Mixed since it is not provided by client.
    @biaol-odata
    biaol-odata committed Dec 20, 2017
    Configuration menu
    Copy the full SHA
    2ce1695 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2018

  1. CR comments.

    @biaol-odata
    biaol-odata committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    243bc90 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2018

  1. Addressing CR comment: using null dependsOnIds of MultipartMixed batc… 

    …h as a flag to uniquely indicate implicit dependsOnIds case
    @biaol-odata
    biaol-odata committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    69b81cf View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2018

  1. Addressed addtional CR comments, primarily: 

    - Changing to use payloadUrlConverter to validate referencing uri for the case of Multipart batch with implicit dependsOnIds.
- Tests added.
    @biaol-odata
    biaol-odata committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    a745e95 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2018

  1. Restricting BatchOperationRequestMessage.dependsOnIds from List<strin… 

    …g> to IEnumerable<string>, not allowing element updates.
    @biaol-odata
    biaol-odata committed Jan 12, 2018
    Configuration menu
    Copy the full SHA
    c7f10a4 View commit details
    Browse the repository at this point in the history