Fix to Issue #541 #542
Closed
Fix to Issue #541 #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There will be an assertion failure complaining "edit link must already be set to location header", if the location header in the OData response is an URI having no local path, e.g. https://graph.microsoft.com Root cause: if the location header in the OData response is an URI having no local path, e.g. https://graph.microsoft.com, it will be added a tailing slash automatically when converted to an Uri object (i.e. https://graph.microsoft.com/ ). therefore, it will always fail, when comparing the location string to an Uri.AbsoluteUri, because of an extra tailing slash. Fix: Convert the location string to a Uri first, when comparing it to an Uri
|
Hi @weiran-ms, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
Merged locally and added test cases, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes issue #541
Description
There will be an assertion failure complaining "edit link must already be set to location header", if the location header in the OData response is an URI having no local path, e.g. https://graph.microsoft.com
Root cause:
if the location header in the OData response is an URI having no local path, e.g. https://graph.microsoft.com, it will be added a tailing slash automatically when converted to an Uri object (i.e. https://graph.microsoft.com/ ). therefore, it will always fail, when comparing the location string to an Uri.AbsoluteUri, because of an extra tailing slash.
Fix: Convert the location string to a Uri first, when comparing it to an Uri
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.
There will be an assertion failure complaining "edit link must already be set to location header", if the location header in the OData response is an URI having no local path, e.g. https://graph.microsoft.com
Root cause:
if the location header in the OData response is an URI having no local path, e.g. https://graph.microsoft.com, it will be added a tailing slash automatically when converted to an Uri object (i.e. https://graph.microsoft.com/ ). therefore, it will always fail, when comparing the location string to an Uri.AbsoluteUri, because of an extra tailing slash.
Fix: Convert the location string to a Uri first, when comparing it to an Uri