Policheck fixes #919
Merged
Policheck fixes #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@biaol-odata, |
robward-ms
approved these changes
Jul 27, 2017
robward-ms
suggested changes
Jul 28, 2017
tools/PoliCheck/RunPoliCheck.cmd
Outdated
| @@ -0,0 +1,2 @@ | |||
| set ENLISTMENT_ROOT=%1 | |||
| 'C:\Program Files (x86)\Microsoft\PoliCheck\Policheck.exe' /FL:'C:\Users\ODatabld\Documents\PoliCheck\subdirs.txt' /T:9 /Sev:'1|2' /O:'c:\Users\ODatabld\Documents\PoliCheck\poli32.xml' | |||
There was a problem hiding this comment.
Since this is using hard-coded paths for the build machines, maybe it's more appropriate to not include in GitHub?
There was a problem hiding this comment.
I am still experimenting it. Not quite working yet.
There was a problem hiding this comment.
@robward-ms This file is not needed now and has been removed from the change.
robward-ms
approved these changes
Jul 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes issues correctly detected by Policheck.
Description
Updating literal strings and DB contents / schema flagged by Policheck.
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.