Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files only on prod to repo and template to generate sitemap #358

Conversation

gathogojr
Copy link
Contributor

@gathogojr gathogojr commented Sep 8, 2023

Since GitHub actions ZipDeploy deployment method DOES NOT preserve any files on the target directory if they're not in the package being deployed, I identified files present in prod (most likely pushed directly) but not in the GitHub repository and added them to the repository so they'll get packaged and published during deployment.

In addition, since a sitemap.xml file is present on prod and a Jekyll template for generating that file didn't exist in the repo, I added such a template that generates both sitemap and sitemap.xml.
I wouldn't say I understand whether or why both are needed but I noticed that feed and feed.xml as well as blog/feed and blog/feed.xml that do something similar also exist in pairs.

Note: You can run jekyll build locally to see the sitemap file that is generated

@ElizabethOkerio
Copy link
Contributor

Where is the template that generates the two files? Does it need to be added here? or how does it work?

@gathogojr
Copy link
Contributor Author

Where is the template that generates the two files? Does it need to be added here? or how does it work?

The two files sitemap and sitemap.xml in this pull request are actually templates that Jekyll uses to generate _site/sitemap and _site/sitemap.xml that look as follows:

<?xml version="1.0" encoding="UTF-8"?>
<urlset xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.sitemaps.org/schemas/sitemap/0.9 http://www.sitemaps.org/schemas/sitemap/0.9/sitemap.xsd" xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
<url>
<loc>https://www.odata.org/ecosystem/consumers/(unofficial)-SSIS-import-script/</loc>
<lastmod>2023-09-08T10:16:03+03:00</lastmod>
</url>
<url>
<loc>https://www.odata.org/ecosystem/consumers/ADO.NET-Driver/</loc>
<lastmod>2023-09-08T10:16:03+03:00</lastmod>
</url>
<url>
<loc>https://www.odata.org/ecosystem/consumers/Access-Odata/</loc>
<lastmod>2023-09-08T10:16:03+03:00</lastmod>
</url>
<url>
<loc>https://www.odata.org/ecosystem/consumers/BOARD/</loc>
<lastmod>2023-09-08T10:16:03+03:00</lastmod>
</url>
<url>
<loc>https://www.odata.org/ecosystem/consumers/Browsers/</loc>
<lastmod>2023-09-08T10:16:03+03:00</lastmod>
</url>
<url>
<loc>https://www.odata.org/ecosystem/consumers/CS-Connect/</loc>
<lastmod>2023-09-08T10:16:03+03:00</lastmod>
</url>
<url>
<loc>https://www.odata.org/ecosystem/consumers/Client-Libraries/</loc>
<lastmod>2023-09-08T10:16:03+03:00</lastmod>
</url>
<url>
<loc>https://www.odata.org/ecosystem/consumers/DataPublic/</loc>
<lastmod>2023-09-08T10:16:03+03:00</lastmod>
</url>
<url>
<loc>https://www.odata.org/ecosystem/consumers/Database-NET-v3/</loc>
<lastmod>2023-09-08T10:16:03+03:00</lastmod>
</url>
<!-- MORE -->
</urlset>

@gathogojr gathogojr force-pushed the fix/add-files-only-on-prod-to-repo-and-template-to-generate-sitemap branch from 9eac2ed to 591453b Compare September 8, 2023 08:09
@gathogojr gathogojr merged commit 60dc250 into OData:master Sep 8, 2023
@gathogojr gathogojr deleted the fix/add-files-only-on-prod-to-repo-and-template-to-generate-sitemap branch September 8, 2023 08:28
@gathogojr gathogojr mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants